You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/03/08 18:42:23 UTC
[GitHub] [maven] rdp opened a new pull request #454: Update README.md
rdp opened a new pull request #454:
URL: https://github.com/apache/maven/pull/454
Attempt to make it clearer how to bootstrap. `Run Maven` wasn't clear which to me.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slachiewicz closed pull request #454: Update README.md
Posted by GitBox <gi...@apache.org>.
slachiewicz closed pull request #454:
URL: https://github.com/apache/maven/pull/454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] lutzhorn commented on a change in pull request #454: Update README.md
Posted by GitBox <gi...@apache.org>.
lutzhorn commented on a change in pull request #454:
URL: https://github.com/apache/maven/pull/454#discussion_r589716609
##########
File path: README.md
##########
@@ -63,10 +63,10 @@ Do you like Apache Maven? Then [donate back to the ASF](https://www.apache.org/f
Quick Build
-------
-If you want to bootstrap Maven, you'll need:
+If you want to bootstrap Maven from source, you'll need:
Review comment:
'Bootstrap' implies 'from source' so this change is redundant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rdp commented on pull request #454: Update README.md
Posted by GitBox <gi...@apache.org>.
rdp commented on pull request #454:
URL: https://github.com/apache/maven/pull/454#issuecomment-800712536
It doesn't add new information but it would have made it clearer in
this instance for myself. Feel free to close if you dislike it.
Cheers!
On 3/8/21, Lutz Horn ***@***.***> wrote:
> @lutzhorn commented on this pull request.
>
>
>
>> - Java 1.8+
> - Maven 3.0.5 or later
> -- Run Maven, specifying a location into which the completed Maven distro
> should be installed:
> +- Run Maven already installed, specifying a location into which the
> completed Maven distro should be installed:
>
> Since an already installed Maven is required in the line above, this change
> adds not new information.
>
> --
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub:
> https://github.com/apache/maven/pull/454#pullrequestreview-606668401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] lutzhorn commented on a change in pull request #454: Update README.md
Posted by GitBox <gi...@apache.org>.
lutzhorn commented on a change in pull request #454:
URL: https://github.com/apache/maven/pull/454#discussion_r589717088
##########
File path: README.md
##########
@@ -63,10 +63,10 @@ Do you like Apache Maven? Then [donate back to the ASF](https://www.apache.org/f
Quick Build
-------
-If you want to bootstrap Maven, you'll need:
+If you want to bootstrap Maven from source, you'll need:
- Java 1.8+
- Maven 3.0.5 or later
-- Run Maven, specifying a location into which the completed Maven distro should be installed:
+- Run Maven already installed, specifying a location into which the completed Maven distro should be installed:
Review comment:
Since an already installed Maven is required in the line above, this change adds not new information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org