[GitHub] gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6129: Add support for 'maxTotalRows' to incremental publishing kafka indexing task and appenderator based realtime task
URL: https://github.com/apache/incubator-druid/pull/6129#discussion_r210988503
 
 

 ##########
 File path: server/src/main/java/io/druid/segment/realtime/appenderator/AppenderatorConfig.java
 ##########
 @@ -30,12 +30,48 @@
 {
   boolean isReportParseExceptions();
 
+  /**
+   * Maximum number of rows in memory before persisting to local storage
+   *
+   * @return
+   */
   int getMaxRowsInMemory();
 
+  /**
+   * Maximum number of bytes (estimated) to store in memory before persisting to local storage
+   *
+   * @return
+   */
   long getMaxBytesInMemory();
 
+
 
 Review comment:
   The extra newline here isn't needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org