You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/30 13:14:36 UTC

[GitHub] [pulsar] eolivelli commented on a diff in pull request #15700: [fix][admin] Fix check on create function class name

eolivelli commented on code in PR #15700:
URL: https://github.com/apache/pulsar/pull/15700#discussion_r884819850


##########
pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/CmdFunctionsTest.java:
##########
@@ -831,7 +845,7 @@ public void testUpdateAuthData() throws Exception {
                 "--jar", URL,
                 "--tenant", "sample",
                 "--namespace", "ns1",
-                "--className", DummyFunction.class.getName(),
+                "--classname", DummyFunction.class.getName(),

Review Comment:
   Why are we changing these tests?
   Are we breaking compatibility?
   I would prefer to not change existing tests if not needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org