You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Nathan Beyer (JIRA)" <ji...@apache.org> on 2006/03/23 07:48:00 UTC
[jira] Created: (HARMONY-239) [classlib][luni] Java 5 enhancements
for java.lang.Float
[classlib][luni] Java 5 enhancements for java.lang.Float
--------------------------------------------------------
Key: HARMONY-239
URL: http://issues.apache.org/jira/browse/HARMONY-239
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Nathan Beyer
Patch for Java 5 enhancements to java.lang.Float.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
RE: [jira] Created: (HARMONY-239) [classlib][luni] Java 5 enhancements for java.lang.Float
Posted by Nathan Beyer <nb...@kc.rr.com>.
There was a problem in the simple caching I put in the class for the valueOf
method. It wasn't discerning between - and + 0.0. I've removed the caching
piece altogether and attached a new diff. Caching of Float and Double
instances probably isn't necessary anyway, but it can always be added later.
This same problem will afflict my post for the Double class enhancements.
Let me know if you want me to post another diff for that as well.
-Nathan
-----Original Message-----
From: Tim Ellison [mailto:t.p.ellison@gmail.com]
Sent: Wednesday, March 29, 2006 5:25 AM
To: harmony-dev@incubator.apache.org
Subject: Re: [jira] Created: (HARMONY-239) [classlib][luni] Java 5
enhancements for java.lang.Float
Nathan, I have failing tests after applying this patch, notably in
LUNI tests
AssertionFailedError: Floattest0 at
tests.api.java.lang.FloatTest.test_valueOfLjava_lang_String(FloatTest.java:5
79)
and
MATH tests
BigDecimalConvertTest#testFloatValuePlusZero()
Please take a look if you have time, otherwise I'll look at it later.
Regards,
Tim
Nathan Beyer (JIRA) wrote:
> [classlib][luni] Java 5 enhancements for java.lang.Float
> --------------------------------------------------------
>
> Key: HARMONY-239
> URL: http://issues.apache.org/jira/browse/HARMONY-239
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
>
>
> Patch for Java 5 enhancements to java.lang.Float.
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
Re: [jira] Created: (HARMONY-239) [classlib][luni] Java 5 enhancements
for java.lang.Float
Posted by Tim Ellison <t....@gmail.com>.
Nathan, I have failing tests after applying this patch, notably in
LUNI tests
AssertionFailedError: Floattest0 at
tests.api.java.lang.FloatTest.test_valueOfLjava_lang_String(FloatTest.java:579)
and
MATH tests
BigDecimalConvertTest#testFloatValuePlusZero()
Please take a look if you have time, otherwise I'll look at it later.
Regards,
Tim
Nathan Beyer (JIRA) wrote:
> [classlib][luni] Java 5 enhancements for java.lang.Float
> --------------------------------------------------------
>
> Key: HARMONY-239
> URL: http://issues.apache.org/jira/browse/HARMONY-239
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
>
>
> Patch for Java 5 enhancements to java.lang.Float.
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
[jira] Commented: (HARMONY-239) [classlib][luni] Java 5
enhancements for java.lang.Float
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-239?page=comments#action_12372630 ]
Nathan Beyer commented on HARMONY-239:
--------------------------------------
Looks good, thank you.
> [classlib][luni] Java 5 enhancements for java.lang.Float
> --------------------------------------------------------
>
> Key: HARMONY-239
> URL: http://issues.apache.org/jira/browse/HARMONY-239
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Assignee: Tim Ellison
> Attachments: Float_java_5_no_cache.diff, Float_java_5_patch.diff
>
> Patch for Java 5 enhancements to java.lang.Float.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-239) [classlib][luni] Java 5 enhancements
for java.lang.Float
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-239?page=all ]
Tim Ellison reassigned HARMONY-239:
-----------------------------------
Assign To: Tim Ellison
> [classlib][luni] Java 5 enhancements for java.lang.Float
> --------------------------------------------------------
>
> Key: HARMONY-239
> URL: http://issues.apache.org/jira/browse/HARMONY-239
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Assignee: Tim Ellison
> Attachments: Float_java_5_patch.diff
>
> Patch for Java 5 enhancements to java.lang.Float.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-239) [classlib][luni] Java 5 enhancements
for java.lang.Float
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-239?page=all ]
Nathan Beyer updated HARMONY-239:
---------------------------------
Attachment: Float_java_5_no_cache.diff
There was an issue with the cache that I put into the valueOf method, so I've removed it. The 'no cache' diff should reflect this, both in the class and test case.
> [classlib][luni] Java 5 enhancements for java.lang.Float
> --------------------------------------------------------
>
> Key: HARMONY-239
> URL: http://issues.apache.org/jira/browse/HARMONY-239
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Assignee: Tim Ellison
> Attachments: Float_java_5_no_cache.diff, Float_java_5_patch.diff
>
> Patch for Java 5 enhancements to java.lang.Float.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-239) [classlib][luni] Java 5
enhancements for java.lang.Float
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-239?page=comments#action_12371867 ]
Nathan Beyer commented on HARMONY-239:
--------------------------------------
After some thought, the caching that's implemented in the valueOf method of the attached diff may not be appropriate or valuable, so feel free to remove it.
> [classlib][luni] Java 5 enhancements for java.lang.Float
> --------------------------------------------------------
>
> Key: HARMONY-239
> URL: http://issues.apache.org/jira/browse/HARMONY-239
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Attachments: Float_java_5_patch.diff
>
> Patch for Java 5 enhancements to java.lang.Float.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-239) [classlib][luni] Java 5 enhancements
for java.lang.Float
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-239?page=all ]
Tim Ellison resolved HARMONY-239:
---------------------------------
Resolution: Fixed
Thanks Nathan,
The no cache patch looks better.
Applied to LUNI module java.lang.Float at repo revision 390180.
Please check that the patch was applied as you expected.
> [classlib][luni] Java 5 enhancements for java.lang.Float
> --------------------------------------------------------
>
> Key: HARMONY-239
> URL: http://issues.apache.org/jira/browse/HARMONY-239
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Assignee: Tim Ellison
> Attachments: Float_java_5_no_cache.diff, Float_java_5_patch.diff
>
> Patch for Java 5 enhancements to java.lang.Float.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-239) [classlib][luni] Java 5 enhancements
for java.lang.Float
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-239?page=all ]
Tim Ellison closed HARMONY-239:
-------------------------------
Verified by Nathan
> [classlib][luni] Java 5 enhancements for java.lang.Float
> --------------------------------------------------------
>
> Key: HARMONY-239
> URL: http://issues.apache.org/jira/browse/HARMONY-239
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Assignee: Tim Ellison
> Attachments: Float_java_5_no_cache.diff, Float_java_5_patch.diff
>
> Patch for Java 5 enhancements to java.lang.Float.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-239) [classlib][luni] Java 5 enhancements
for java.lang.Float
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-239?page=all ]
Nathan Beyer updated HARMONY-239:
---------------------------------
Attachment: Float_java_5_patch.diff
> [classlib][luni] Java 5 enhancements for java.lang.Float
> --------------------------------------------------------
>
> Key: HARMONY-239
> URL: http://issues.apache.org/jira/browse/HARMONY-239
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Attachments: Float_java_5_patch.diff
>
> Patch for Java 5 enhancements to java.lang.Float.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira