You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/09/28 16:12:59 UTC
[PR] [SPARK-59830] Unify K8s event sources into `spark-kubernetes-operator` [spark-kubernetes-operator]
dongjoon-hyun opened a new pull request, #899:
URL: https://github.com/apache/spark-kubernetes-operator/pull/899
[SPARK-59830] Unify K8s event sources into `spark-kubernetes-operator`
### What changes were proposed in this pull request?
This PR aims to unify K8s event sources (`reportingComponent` and `source.component`) into `spark-kubernetes-operator` and document it as stable. The JOSDK controller names are unchanged because they are also used in metric names.
| Kind | Before | After |
|---|---|---|
| `SparkApplication` | `sparkappreconciler` | `spark-kubernetes-operator` |
| `SparkCluster` | `sparkclusterreconciler` | `spark-kubernetes-operator` |
### Why are the changes needed?
The previous values are the JOSDK default controller names, i.e., the lowercased reconciler class names. They differ per kind and change silently when a class is renamed. A single stable name lets users list all events of the operator with one field selector.
```bash
kubectl get events -A --field-selector reportingComponent=spark-kubernetes-operator
```
### Does this PR introduce _any_ user-facing change?
No, because K8s events are not released yet.
### How was this patch tested?
Pass the CIs with the newly added unit test and the updated `events` e2e test.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59830] Unify K8s event sources into `spark-kubernetes-operator` [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #899:
URL: https://github.com/apache/spark-kubernetes-operator/pull/899#issuecomment-5874360205
Thank you always, @peter-toth !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59830] Unify K8s event sources into `spark-kubernetes-operator` [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #899: [SPARK-59830] Unify K8s event sources into `spark-kubernetes-operator`
URL: https://github.com/apache/spark-kubernetes-operator/pull/899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org