You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@river.apache.org by "Mark Brouwer (JIRA)" <ji...@apache.org> on 2007/05/03 08:48:15 UTC

[jira] Created: (RIVER-22) NPE in net.jini.jeri.tcp.TcpEndpoint$ConnectionImpl.checkConnectPermission

NPE in net.jini.jeri.tcp.TcpEndpoint$ConnectionImpl.checkConnectPermission
--------------------------------------------------------------------------

                 Key: RIVER-22
                 URL: https://issues.apache.org/jira/browse/RIVER-22
             Project: River
          Issue Type: Bug
            Reporter: Mark Brouwer
         Assigned To: Mark Brouwer


Running some stress tests it is possible an NPE is thrown when the sockets used by a {{TcpEndpoint}} has been closed while an attempt to invoke a remote method takes place, this is related to a bug reported as [#6243057|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6243057], see also this [thread|http://archives.java.sun.com/cgi-bin/wa?A2=ind0404&L=jini-users&F=&S=&P=18968].

{noformat:nopanel}
02-May-2007 17:01:12 org.cheiron.seven.core.ContainerManager notifyServiceDestroyed (oid=1.3.6.1.4.12543.2.0, group=default, instance=master)
INFO: JSC Service with ID 1.2.3.3_load is destroyed, connector unexported and container managed resources are released
java.lang.NullPointerException
        at net.jini.jeri.tcp.TcpEndpoint$ConnectionImpl.checkConnectPermission(TcpEndpoint.java:892)
        at net.jini.jeri.tcp.TcpEndpoint$ConnectionEndpointImpl.connect(TcpEndpoint.java:754)
        at net.jini.jeri.connection.ConnectionManager.connect(ConnectionManager.java:205)
        at net.jini.jeri.connection.ConnectionManager$ReqIterator.next(ConnectionManager.java:629)
        at net.jini.jeri.BasicObjectEndpoint$1.next(BasicObjectEndpoint.java:371)
        at net.jini.jeri.BasicInvocationHandler.invokeRemoteMethodOnce(BasicInvocationHandler.java:708)
        at net.jini.jeri.BasicInvocationHandler.invokeRemoteMethod(BasicInvocationHandler.java:659)
        at net.jini.jeri.BasicInvocationHandler.invoke(BasicInvocationHandler.java:528)
        at org.cheiron.seven.proxy.BasicInvocationHandler.invokeMethod(BasicInvocationHandler.java:324)
        at org.cheiron.seven.proxy.BasicInvocationHandler.invoke(BasicInvocationHandler.java:129)
        at org.cheiron.seven.proxy.StubInvokerHandler.invoke(StubInvokerHandler.java:142)
        at org.cheiron.seven.proxy.BasicInvocationHandler.invokeMethod(BasicInvocationHandler.java:324)
        at org.cheiron.seven.proxy.ServiceStubProxyHandler.specializedInvoke(ServiceStubProxyHandler.java:164)
        at org.cheiron.seven.proxy.BasicInvocationHandler.invoke(BasicInvocationHandler.java:119)
        at com.sun.jini.outrigger.$Proxy141.take(Unknown Source)
        at com.sun.jini.outrigger.SpaceProxy2.take(SpaceProxy2.java:411)
        at sun.reflect.GeneratedMethodAccessor87.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:585)
        at org.cheiron.seven.proxy.BasicInvocationHandler.invokeMethod(BasicInvocationHandler.java:328)
        at org.cheiron.seven.proxy.BasicInvocationHandler.invoke(BasicInvocationHandler.java:129)
        at $Proxy140.take(Unknown Source)
        at x.y.z.javaspace.JavaSpaceAccessorImpl$EntryTaker.run(JavaSpaceAccessorImpl.java:377)
        at org.cheiron.util.thread.ThreadPoolImpl$ContextTask$1.run(ThreadPoolImpl.java:1527)
        at org.cheiron.seven.security.ContextSecurityManager$3$1.run(ContextSecurityManager.java:410)
        at java.security.AccessController.doPrivileged(Native Method)
        at org.cheiron.util.thread.ThreadPoolImpl$ContextTask.run(ThreadPoolImpl.java:1522)
        at org.cheiron.util.thread.ThreadPoolImpl$WorkerThread.run(ThreadPoolImpl.java:2657)
{noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Updated: (RIVER-22) NPE in net.jini.jeri.tcp.TcpEndpoint$ConnectionImpl.checkConnectPermission

Posted by Peter Jones <pe...@sun.com>.

On Tue, Jun 10, 2008 at 08:55:30PM +0200, Mark Brouwer wrote:
> Peter Jones wrote:
>> On Sun, Jun 01, 2008 at 01:59:44PM -0700, Mark Brouwer (JIRA) wrote:
>>>      [ https://issues.apache.org/jira/browse/RIVER-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>>
>>> Mark Brouwer updated RIVER-22:
>>> ------------------------------
>>>
>>>     Attachment: RIVER-22.patch
>>>
>>> Proposed patch for review.
>>
>> (I had missed that this problem had been reported for non-server
>> sockets as well as for server sockets, the case we added the
>> workaround for in Porter.)
>>
>> Proposed changes look fine to me.
>>
>> I might be tempted to add an assertion in the ConnectionImpl
>> constructor that the socket is connected, as that is an assumption
>> being made (a safe one, I believe).
>
> Added the assertion, new patch attached.

Looks fine to me.

-- Peter

Re: [jira] Updated: (RIVER-22) NPE in net.jini.jeri.tcp.TcpEndpoint$ConnectionImpl.checkConnectPermission

Posted by Mark Brouwer <ma...@marbro.org>.

Peter Jones wrote:
> On Sun, Jun 01, 2008 at 01:59:44PM -0700, Mark Brouwer (JIRA) wrote:
>>      [ https://issues.apache.org/jira/browse/RIVER-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Mark Brouwer updated RIVER-22:
>> ------------------------------
>>
>>     Attachment: RIVER-22.patch
>>
>> Proposed patch for review.
> 
> (I had missed that this problem had been reported for non-server
> sockets as well as for server sockets, the case we added the
> workaround for in Porter.)
> 
> Proposed changes look fine to me.
> 
> I might be tempted to add an assertion in the ConnectionImpl
> constructor that the socket is connected, as that is an assumption
> being made (a safe one, I believe).

Added the assertion, new patch attached.
-- 
Mark