[GitHub] [shardingsphere] terrymanu commented on a change in pull request #6701: add ProxyDataSourceContextTest

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #6701:
URL: https://github.com/apache/shardingsphere/pull/6701#discussion_r467419926



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/pom.xml
##########
@@ -132,5 +132,18 @@
             <artifactId>postgresql</artifactId>
             <scope>runtime</scope>
         </dependency>
+
+        <dependency>
+            <groupId>org.powermock</groupId>
+            <artifactId>powermock-module-junit4</artifactId>
+            <version>1.7.4</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.powermock</groupId>
+            <artifactId>powermock-api-mockito2</artifactId>
+            <version>1.7.4</version>
+            <scope>test</scope>
+        </dependency>

Review comment:
       Please do not add other dependency if unnecessary, the reason are:
   1. It is better to use one mock framework
   2. If we need add more mock framework, please add the notice and licenses too




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org