You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/24 12:58:06 UTC
[GitHub] [hadoop-ozone] maobaolong opened a new pull request #1343: HDDS-4137. Turn on the verbose mode of safe mode check on testlib
maobaolong opened a new pull request #1343:
URL: https://github.com/apache/hadoop-ozone/pull/1343
## What changes were proposed in this pull request?
Turn on the verbose mode of safe mode check on testlib
## What is the link to the Apache JIRA
HDDS-4137
## How was this patch tested?
No need
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai edited a comment on pull request #1343: HDDS-4137. Turn on the verbose mode of safe mode check on testlib
Posted by GitBox <gi...@apache.org>.
adoroszlai edited a comment on pull request #1343:
URL: https://github.com/apache/hadoop-ozone/pull/1343#issuecomment-680715682
@maobaolong Thanks for updating the patch. Sorry, I forgot that `OZONE_SAFEMODE_STATUS_COMMAND` needs to have a default value, so the following change is also needed:
```diff
diff --git hadoop-ozone/dist/src/main/compose/testlib.sh hadoop-ozone/dist/src/main/compose/testlib.sh
index 24a7de3b1..228572fe2 100755
--- hadoop-ozone/dist/src/main/compose/testlib.sh
+++ hadoop-ozone/dist/src/main/compose/testlib.sh
@@ -63,7 +63,7 @@ find_tests(){
## @description wait until safemode exit (or 180 seconds)
wait_for_safemode_exit(){
# version-dependent
- : ${OZONE_ADMIN_COMMAND:=admin}
+ : ${OZONE_SAFEMODE_STATUS_COMMAND:=ozone admin safemode status --verbose}
#Reset the timer
SECONDS=0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong closed pull request #1343: HDDS-4137. Turn on the verbose mode of safe mode check on testlib
Posted by GitBox <gi...@apache.org>.
maobaolong closed pull request #1343:
URL: https://github.com/apache/hadoop-ozone/pull/1343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1343: HDDS-4137. Turn on the verbose mode of safe mode check on testlib
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1343:
URL: https://github.com/apache/hadoop-ozone/pull/1343#issuecomment-680124975
@adoroszlai Thanks very much for show me this tip, I think it can help me to pass the acceptance test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong closed pull request #1343: HDDS-4137. Turn on the verbose mode of safe mode check on testlib
Posted by GitBox <gi...@apache.org>.
maobaolong closed pull request #1343:
URL: https://github.com/apache/hadoop-ozone/pull/1343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong closed pull request #1343: HDDS-4137. Turn on the verbose mode of safe mode check on testlib
Posted by GitBox <gi...@apache.org>.
maobaolong closed pull request #1343:
URL: https://github.com/apache/hadoop-ozone/pull/1343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong closed pull request #1343: HDDS-4137. Turn on the verbose mode of safe mode check on testlib
Posted by GitBox <gi...@apache.org>.
maobaolong closed pull request #1343:
URL: https://github.com/apache/hadoop-ozone/pull/1343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1343: HDDS-4137. Turn on the verbose mode of safe mode check on testlib
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1343:
URL: https://github.com/apache/hadoop-ozone/pull/1343#issuecomment-680715682
@maobaolong Thanks for updating the patch. Sorry, I forgot that `OZONE_SAFEMODE_STATUS_COMMAND` needs to have a default value, so the following change is needed:
```diff
diff --git hadoop-ozone/dist/src/main/compose/testlib.sh hadoop-ozone/dist/src/main/compose/testlib.sh
index 24a7de3b1..228572fe2 100755
--- hadoop-ozone/dist/src/main/compose/testlib.sh
+++ hadoop-ozone/dist/src/main/compose/testlib.sh
@@ -63,7 +63,7 @@ find_tests(){
## @description wait until safemode exit (or 180 seconds)
wait_for_safemode_exit(){
# version-dependent
- : ${OZONE_ADMIN_COMMAND:=admin}
+ : ${OZONE_SAFEMODE_STATUS_COMMAND:=ozone admin safemode status --verbose}
#Reset the timer
SECONDS=0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on pull request #1343: HDDS-4137. Turn on the verbose mode of safe mode check on testlib
Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1343:
URL: https://github.com/apache/hadoop-ozone/pull/1343#issuecomment-682270914
@adoroszlai Thank you for trigger CI checks for me, I see full green now, 😁. PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong closed pull request #1343: HDDS-4137. Turn on the verbose mode of safe mode check on testlib
Posted by GitBox <gi...@apache.org>.
maobaolong closed pull request #1343:
URL: https://github.com/apache/hadoop-ozone/pull/1343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #1343: HDDS-4137. Turn on the verbose mode of safe mode check on testlib
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1343:
URL: https://github.com/apache/hadoop-ozone/pull/1343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org