[Bug 3109] RFE: really simple "this is ham" shortcircuiting

[bu...@bugzilla.spamassassin.org]

http://issues.apache.org/SpamAssassin/show_bug.cgi?id=3109





------- Additional Comments From dallase@nmgi.com  2006-05-12 13:27 -------
i'm still testing,  but it appears there is a small problem with a couple
priorities.   looks like setting priorities of -998 and -999 fail because they
are used by

$MISSING_REQUIRED_VALUE     = -998;
$INVALID_VALUE              = -999;

In Conf/Parser.pm, the $ret value set from

      my $ret = &{$cmd->{code}} ($conf, $cmd->{setting}, $value, $line);

is the priority.  which then matches 

      if ($ret && $ret eq $Mail::SpamAssassin::Conf::INVALID_VALUE)

and

      elsif ($ret && $ret eq $Mail::SpamAssassin::Conf::MISSING_REQUIRED_VALUE)

and causes goto failed_line.

# spamassassin --lint -D 2>&1 | grep USER 2>&1
priority USER_IN_BLACKLIST_TO   -999
KEY=priority VALUE=USER_IN_BLACKLIST_TO -999
PARSE_ERROR RET=-999 IV=-999 KEY=priority VALUE=USER_IN_BLACKLIST_TO    -999
[24595] warn: config: SpamAssassin failed to parse line,
"USER_IN_BLACKLIST_TO_-999" is not valid for "priority", skipping: priority
USER_IN_BLACKLIST_TO_-999
priority USER_IN_BLACKLIST      -998
KEY=priority VALUE=USER_IN_BLACKLIST    -998
[24595] warn: config: SpamAssassin failed to parse line, no value provided for
"priority", skipping: priority USER_IN_BLACKLIST_-998
priority USER_IN_WHITELIST     -990
KEY=priority VALUE=USER_IN_WHITELIST     -990
NEXT, RET=-990 KEY=priority VALUE=USER_IN_WHITELIST     -990
priority USER_IN_DEF_WHITELIST -989
KEY=priority VALUE=USER_IN_DEF_WHITELIST -989
NEXT, RET=-989 KEY=priority VALUE=USER_IN_DEF_WHITELIST -989
priority USER_IN_ALL_SPAM_TO   -988
KEY=priority VALUE=USER_IN_ALL_SPAM_TO   -988
NEXT, RET=-988 KEY=priority VALUE=USER_IN_ALL_SPAM_TO   -988
[24595] dbg: shortcircuit: adding USER_IN_WHITELIST default
[24595] dbg: shortcircuit: adding USER_IN_DEF_WHITELIST default
[24595] dbg: shortcircuit: adding USER_IN_ALL_SPAM_TO default
[24595] dbg: shortcircuit: adding USER_IN_BLACKLIST default
[24595] dbg: shortcircuit: adding USER_IN_BLACKLIST_TO default




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.