[GitHub] [nuttx] Gary-Hobson commented on pull request #7678: drivers/segger: Add Segger RTT stream support

[GitBox <gi...@apache.org>]

Gary-Hobson commented on PR #7678:
URL: https://github.com/apache/nuttx/pull/7678#issuecomment-1328076571

   I have changed to initializing the RTT buffer in lib_rttoutstream, but I still feel like this is not a good design.
   
   This can cause some unnecessary troubles:
   When calling lib_rttinstream to initialize channel 0, it will cause an internal static buffer leak, which we cannot release or use
   
   We need to get some internal data structures of Segger RTT in the code, its style is not compatible with nuttx
   
   The initialization of the segger RTT channel is a very independent thing that only needs to be done once. There is no need to process it once in different codes, and there is no need for uninitialization


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org