You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/16 06:35:37 UTC
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20404: fix: suppress translation warning in jest
zhaoyongjie commented on code in PR #20404:
URL: https://github.com/apache/superset/pull/20404#discussion_r898742481
##########
superset-frontend/spec/helpers/shim.ts:
##########
@@ -81,3 +81,5 @@ setupSupersetClient();
jest.mock('src/hooks/useTabId', () => ({
useTabId: () => 1,
}));
+
+process.env.WEBPACK_MODE = 'test';
Review Comment:
the environment variable `WEBPACK_MODE` is defined at webpack.config.js
##########
superset-frontend/spec/helpers/shim.ts:
##########
@@ -81,3 +81,5 @@ setupSupersetClient();
jest.mock('src/hooks/useTabId', () => ({
useTabId: () => 1,
}));
+
+process.env.WEBPACK_MODE = 'test';
Review Comment:
the environment variable `WEBPACK_MODE` was defined at webpack.config.js
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org