You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by bu...@apache.org on 2005/04/14 22:51:46 UTC

DO NOT REPLY [Bug 34459] New: - RequestEntity, EntityEnclosingMethod have inconsistent Javadocs, use deprecated variables

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34459>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34459

           Summary: RequestEntity, EntityEnclosingMethod have inconsistent
                    Javadocs, use deprecated variables
           Product: HttpClient
           Version: 3.0 RC2
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Commons HttpClient
        AssignedTo: httpclient-dev@jakarta.apache.org
        ReportedBy: olegk@apache.org


Robert Manning <Robert.Manning at collabraspace.com> reported a problem on the
httpclient-user list regarding inconsistencies in javadoc of RequestEntity
interface and EntityEnclosingMethod class. This prompted me to review the said
classes. I have discovered several issues that must be dealt with before 3.0
goes final. 

(1) There's virtually no test coverage for the EntityEnclosingMethod class
(2) The code in EntityEnclosingMethod class extensively uses deprecated methods
and variables beyond what is required to maintain backward compatibility with
2.0.x API
(3) Existing code cannot gracefully handle faulty RequestEntity implementations
if the getContentLength method returns a negative value < -2

I have committed additional test cases to cover the most fundamental
functionality of EntityEnclosingMethod:
http://svn.apache.org/repos/asf/jakarta/commons/proper/httpclient/trunk/src/test/org/apache/commons/httpclient/TestEntityEnclosingMethod.java

I will submit a patch addressing issues (2) and (3) shortly

Oleg

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org