You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Dave Watson (JIRA)" <ji...@apache.org> on 2011/08/24 18:46:29 UTC

[jira] [Created] (THRIFT-1287) thrift: start refactoring some of the C++ processor

 thrift: start refactoring some of the C++ processor

-----------------------------------------------------

                 Key: THRIFT-1287
                 URL: https://issues.apache.org/jira/browse/THRIFT-1287
             Project: Thrift
          Issue Type: Improvement
          Components: C++ - Library
            Reporter: Dave Watson
            Priority: Minor
         Attachments: 0014-thrift-start-refactoring-some-of-the-C-processor-cod.patch

>From 527b9dc312e3dc45a18e15b50c0daf7dab52bfb5 Mon Sep 17 00:00:00 2001
From: Adam Simpkins <si...@fb.com>
Date: Sat, 3 Apr 2010 02:49:48 +0000
Subject: [PATCH 14/33] thrift: start refactoring some of the C++ processor
 code generation

Summary:
This adds a ProcessorGenerator class to store all of the local variables
used by generate_service_processor().  This way we can break up that
giant function into some smaller pieces.

The code is still pretty ugly, but it's a start.

Test Plan:
Built [two fb projects], and some additional thrift test files, and made
sure the generated files were identical both before and after these
changes.

Revert Plan:
OK


Conflicts:

	compiler/cpp/src/generate/t_cpp_generator.cc
---
 compiler/cpp/src/generate/t_cpp_generator.cc |  346 ++++++++++++++++----------
 1 files changed, 216 insertions(+), 130 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1287) thrift: start refactoring some of the C++ processor

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090451#comment-13090451 ] 

Hudson commented on THRIFT-1287:
--------------------------------

Integrated in Thrift #232 (See [https://builds.apache.org/job/Thrift/232/])
    THRIFT-1287. cpp: start refactoring some of the C++ processor 

Move the generation of Processors into a separate subclass.

Patch: Adam Simpkins

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1161223
Files : 
* /thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc


>  thrift: start refactoring some of the C++ processor

> -----------------------------------------------------
>
>                 Key: THRIFT-1287
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1287
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Assignee: Dave Watson
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: 0014-thrift-start-refactoring-some-of-the-C-processor-cod.patch
>
>
> From 527b9dc312e3dc45a18e15b50c0daf7dab52bfb5 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Sat, 3 Apr 2010 02:49:48 +0000
> Subject: [PATCH 14/33] thrift: start refactoring some of the C++ processor
>  code generation
> Summary:
> This adds a ProcessorGenerator class to store all of the local variables
> used by generate_service_processor().  This way we can break up that
> giant function into some smaller pieces.
> The code is still pretty ugly, but it's a start.
> Test Plan:
> Built [two fb projects], and some additional thrift test files, and made
> sure the generated files were identical both before and after these
> changes.
> Revert Plan:
> OK
> Conflicts:
> 	compiler/cpp/src/generate/t_cpp_generator.cc
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |  346 ++++++++++++++++----------
>  1 files changed, 216 insertions(+), 130 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1287) thrift: start refactoring some of the C++ processor

Posted by "Dave Watson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Watson updated THRIFT-1287:
--------------------------------

    Attachment: 0014-thrift-start-refactoring-some-of-the-C-processor-cod.patch

>  thrift: start refactoring some of the C++ processor

> -----------------------------------------------------
>
>                 Key: THRIFT-1287
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1287
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Priority: Minor
>         Attachments: 0014-thrift-start-refactoring-some-of-the-C-processor-cod.patch
>
>
> From 527b9dc312e3dc45a18e15b50c0daf7dab52bfb5 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Sat, 3 Apr 2010 02:49:48 +0000
> Subject: [PATCH 14/33] thrift: start refactoring some of the C++ processor
>  code generation
> Summary:
> This adds a ProcessorGenerator class to store all of the local variables
> used by generate_service_processor().  This way we can break up that
> giant function into some smaller pieces.
> The code is still pretty ugly, but it's a start.
> Test Plan:
> Built [two fb projects], and some additional thrift test files, and made
> sure the generated files were identical both before and after these
> changes.
> Revert Plan:
> OK
> Conflicts:
> 	compiler/cpp/src/generate/t_cpp_generator.cc
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |  346 ++++++++++++++++----------
>  1 files changed, 216 insertions(+), 130 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (THRIFT-1287) thrift: start refactoring some of the C++ processor

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-1287.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.8
         Assignee: Dave Watson

I just committed this.

>  thrift: start refactoring some of the C++ processor

> -----------------------------------------------------
>
>                 Key: THRIFT-1287
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1287
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>            Reporter: Dave Watson
>            Assignee: Dave Watson
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: 0014-thrift-start-refactoring-some-of-the-C-processor-cod.patch
>
>
> From 527b9dc312e3dc45a18e15b50c0daf7dab52bfb5 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins <si...@fb.com>
> Date: Sat, 3 Apr 2010 02:49:48 +0000
> Subject: [PATCH 14/33] thrift: start refactoring some of the C++ processor
>  code generation
> Summary:
> This adds a ProcessorGenerator class to store all of the local variables
> used by generate_service_processor().  This way we can break up that
> giant function into some smaller pieces.
> The code is still pretty ugly, but it's a start.
> Test Plan:
> Built [two fb projects], and some additional thrift test files, and made
> sure the generated files were identical both before and after these
> changes.
> Revert Plan:
> OK
> Conflicts:
> 	compiler/cpp/src/generate/t_cpp_generator.cc
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |  346 ++++++++++++++++----------
>  1 files changed, 216 insertions(+), 130 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira