[incubator-pinot] branch improve-segment-validator updated: Add Precondition on assignedInstances before updating zk

[jl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jlli pushed a commit to branch improve-segment-validator
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/improve-segment-validator by this push:
     new 43b849e  Add Precondition on assignedInstances before updating zk
43b849e is described below

commit 43b849e388840c7dee7b729429240cd2a303827d
Author: jackjlli <jl...@linkedin.com>
AuthorDate: Thu Feb 21 16:17:58 2019 -0800

    Add Precondition on assignedInstances before updating zk
---
 .../apache/pinot/controller/helix/core/PinotHelixResourceManager.java    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
index 18100ed..ef119aa 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
@@ -1467,6 +1467,7 @@ public class PinotHelixResourceManager {
 
   public void addNewSegment(@Nonnull SegmentMetadata segmentMetadata, @Nonnull String downloadUrl, String crypter,
       @Nonnull List<String> assignedInstances) {
+    Preconditions.checkNotNull(assignedInstances, "Assigned Instances should not be null!");
     String segmentName = segmentMetadata.getName();
     String offlineTableName = TableNameBuilder.OFFLINE.tableNameWithType(segmentMetadata.getTableName());
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org