You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2017/08/21 14:35:15 UTC
Review Request 61784: (preview) Service and Patch Upgrade Catalog
Changes for 2.6 - patch for trunk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61784/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-21728
https://issues.apache.org/jira/browse/AMBARI-21728
Repository: ambari
Description
-------
Service and Patch Upgrade Catalog Changes for 2.6 - patch for trunk
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java ef343d5b39
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 04e4c66759
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DbmsHelper.java b30d01bb3c
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/GenericDbmsHelper.java e2a1f38bd2
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/H2Helper.java 91905e4770
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/MySqlHelper.java 0daea72b4b
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/OracleHelper.java 73356d16e3
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/PostgresHelper.java 37c11840a4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bcc8328366
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java 2227675478
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 230cd950ca
ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java b4ffbf19c1
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/61784/diff/1/
Testing
-------
tests are running
Current upgrade to trunk is broken due to existing code that removes logsearch config properties. As a result, new logsearch configs become selected, but have no service mapping and DB consistency check fails. Investigating that.
Thanks,
Dmitro Lisnichenko
Re: Review Request 61784: (preview) Service and Patch Upgrade Catalog
Changes for 2.6 - patch for trunk
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61784/#review183356
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Aug. 21, 2017, 10:35 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61784/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 10:35 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21728
> https://issues.apache.org/jira/browse/AMBARI-21728
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Service and Patch Upgrade Catalog Changes for 2.6 - patch for trunk
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java ef343d5b39
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 04e4c66759
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DbmsHelper.java b30d01bb3c
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/GenericDbmsHelper.java e2a1f38bd2
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/H2Helper.java 91905e4770
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/MySqlHelper.java 0daea72b4b
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/OracleHelper.java 73356d16e3
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/PostgresHelper.java 37c11840a4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bcc8328366
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java 2227675478
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 230cd950ca
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java b4ffbf19c1
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61784/diff/1/
>
>
> Testing
> -------
>
> tests are running
>
> Current upgrade to trunk is broken due to existing code that removes logsearch config properties. As a result, new logsearch configs become selected, but have no service mapping and DB consistency check fails. Investigating that.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 61784: Service and Patch Upgrade Catalog Changes
for 2.6 - patch for trunk
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61784/#review183472
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 22, 2017, 8:47 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61784/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 8:47 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21728
> https://issues.apache.org/jira/browse/AMBARI-21728
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Service and Patch Upgrade Catalog Changes for 2.6 - patch for trunk
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java ef343d5b39
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 04e4c66759
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DbmsHelper.java b30d01bb3c
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/GenericDbmsHelper.java e2a1f38bd2
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/H2Helper.java 91905e4770
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/MySqlHelper.java 0daea72b4b
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/OracleHelper.java 73356d16e3
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/PostgresHelper.java 37c11840a4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bcc8328366
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java 2227675478
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 230cd950ca
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java b4ffbf19c1
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java baae4c5217
>
>
> Diff: https://reviews.apache.org/r/61784/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
> Current upgrade to trunk is broken due to existing code that removes logsearch config properties. As a result, new logsearch configs become selected, but have no service mapping and DB consistency check fails. Going to open a jira for component owners regarding wrong way to remove configs (not sure why they did this that way)
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 61784: Service and Patch Upgrade Catalog Changes
for 2.6 - patch for trunk
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61784/
-----------------------------------------------------------
(Updated Aug. 22, 2017, 3:47 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
fixed failing unit tests
Summary (updated)
-----------------
Service and Patch Upgrade Catalog Changes for 2.6 - patch for trunk
Bugs: AMBARI-21728
https://issues.apache.org/jira/browse/AMBARI-21728
Repository: ambari
Description
-------
Service and Patch Upgrade Catalog Changes for 2.6 - patch for trunk
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java ef343d5b39
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 04e4c66759
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DbmsHelper.java b30d01bb3c
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/GenericDbmsHelper.java e2a1f38bd2
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/H2Helper.java 91905e4770
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/MySqlHelper.java 0daea72b4b
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/OracleHelper.java 73356d16e3
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/PostgresHelper.java 37c11840a4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java bcc8328366
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java 2227675478
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 230cd950ca
ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java b4ffbf19c1
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java baae4c5217
Diff: https://reviews.apache.org/r/61784/diff/2/
Changes: https://reviews.apache.org/r/61784/diff/1-2/
Testing (updated)
-------
mvn clean test
Current upgrade to trunk is broken due to existing code that removes logsearch config properties. As a result, new logsearch configs become selected, but have no service mapping and DB consistency check fails. Going to open a jira for component owners regarding wrong way to remove configs (not sure why they did this that way)
Thanks,
Dmitro Lisnichenko