You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2016/10/27 01:12:22 UTC
[Impala-ASF-CR] IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate minidump collection testdata.py
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4858
Change subject: IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate_minidump_collection_testdata.py
......................................................................
IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate_minidump_collection_testdata.py
These host names don't need to be in cloudera.com.
Change-Id: Icad9ba6ccba745ad3017cd6ad1c2a11c6af9cb42
---
M bin/generate_minidump_collection_testdata.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/4858/1
--
To view, visit http://gerrit.cloudera.org:8080/4858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icad9ba6ccba745ad3017cd6ad1c2a11c6af9cb42
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate minidump collection testdata.py
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate_minidump_collection_testdata.py
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icad9ba6ccba745ad3017cd6ad1c2a11c6af9cb42
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate minidump collection testdata.py
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate_minidump_collection_testdata.py
......................................................................
Patch Set 1: Verified+1
+1ing since this only changes a comment and pre-commit tests won't do anything.
--
To view, visit http://gerrit.cloudera.org:8080/4858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icad9ba6ccba745ad3017cd6ad1c2a11c6af9cb42
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate minidump collection testdata.py
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate_minidump_collection_testdata.py
......................................................................
IMPALA-4380: Remove 'cloudera' from hostnames in bin/generate_minidump_collection_testdata.py
These host names don't need to be in cloudera.com.
Change-Id: Icad9ba6ccba745ad3017cd6ad1c2a11c6af9cb42
Reviewed-on: http://gerrit.cloudera.org:8080/4858
Reviewed-by: Taras Bobrovytsky <tb...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M bin/generate_minidump_collection_testdata.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Taras Bobrovytsky: Looks good to me, approved
Tim Armstrong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icad9ba6ccba745ad3017cd6ad1c2a11c6af9cb42
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>