You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by bhavik patel <bh...@gmail.com> on 2017/08/11 08:34:39 UTC
Review Request 61591: RANGER-1717 : User with "KEYADMIN" role is not
able to see "Audit => Admin" logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61591/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-1717
https://issues.apache.org/jira/browse/RANGER-1717
Repository: ranger
Description
-------
Currently user with "KEYADMIN" role is not able to see "Audit => Admin" logs when given permission for audit tab, it gives "403 Forbidden" error.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 7d1573d
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 7618981
Diff: https://reviews.apache.org/r/61591/diff/1/
Testing
-------
1. Verified "Audit => Admin" logs when user is logged in with "KEYADMIN" role.
Thanks,
bhavik patel
Re: Review Request 61591: RANGER-1717 : User with "KEYADMIN" role is
not able to see "Audit => Admin" logs
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61591/#review183418
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java
Line 33 (original), 33 (patched)
<https://reviews.apache.org/r/61591/#comment259431>
This patch does not apply to master branch. Please check and update the patch.
- Velmurugan Periasamy
On Aug. 11, 2017, 8:34 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61591/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2017, 8:34 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1717
> https://issues.apache.org/jira/browse/RANGER-1717
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently user with "KEYADMIN" role is not able to see "Audit => Admin" logs when given permission for audit tab, it gives "403 Forbidden" error.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 7d1573d
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 7618981
>
>
> Diff: https://reviews.apache.org/r/61591/diff/1/
>
>
> Testing
> -------
>
> 1. Verified "Audit => Admin" logs when user is logged in with "KEYADMIN" role.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 61591: RANGER-1717 : User with "KEYADMIN" role is
not able to see "Audit => Admin" logs
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61591/#review183683
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Aug. 22, 2017, 5:35 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61591/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 5:35 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1717
> https://issues.apache.org/jira/browse/RANGER-1717
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently user with "KEYADMIN" role is not able to see "Audit => Admin" logs when given permission for audit tab, it gives "403 Forbidden" error.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 7d1573d
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 302076e
>
>
> Diff: https://reviews.apache.org/r/61591/diff/2/
>
>
> Testing
> -------
>
> 1. Verified "Audit => Admin" logs when user is logged in with "KEYADMIN" role.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 61591: RANGER-1717 : User with "KEYADMIN" role is
not able to see "Audit => Admin" logs
Posted by Ankita Sinha <an...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61591/#review183700
-----------------------------------------------------------
Ship it!
Ship It!
- Ankita Sinha
On Aug. 22, 2017, 5:35 a.m., bhavik patel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61591/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 5:35 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1717
> https://issues.apache.org/jira/browse/RANGER-1717
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently user with "KEYADMIN" role is not able to see "Audit => Admin" logs when given permission for audit tab, it gives "403 Forbidden" error.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 7d1573d
> security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 302076e
>
>
> Diff: https://reviews.apache.org/r/61591/diff/2/
>
>
> Testing
> -------
>
> 1. Verified "Audit => Admin" logs when user is logged in with "KEYADMIN" role.
>
>
> Thanks,
>
> bhavik patel
>
>
Re: Review Request 61591: RANGER-1717 : User with "KEYADMIN" role is
not able to see "Audit => Admin" logs
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61591/
-----------------------------------------------------------
(Updated Aug. 22, 2017, 5:35 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Updated the patch as per latest commit.
Bugs: RANGER-1717
https://issues.apache.org/jira/browse/RANGER-1717
Repository: ranger
Description
-------
Currently user with "KEYADMIN" role is not able to see "Audit => Admin" logs when given permission for audit tab, it gives "403 Forbidden" error.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 7d1573d
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 302076e
Diff: https://reviews.apache.org/r/61591/diff/2/
Changes: https://reviews.apache.org/r/61591/diff/1-2/
Testing
-------
1. Verified "Audit => Admin" logs when user is logged in with "KEYADMIN" role.
Thanks,
bhavik patel