You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nicolas Spiegelberg (Created) (JIRA)" <ji...@apache.org> on 2011/11/12 03:58:51 UTC
[jira] [Created] (HBASE-4778) Don't ignore corrupt StoreFiles when
opening a region
Don't ignore corrupt StoreFiles when opening a region
-----------------------------------------------------
Key: HBASE-4778
URL: https://issues.apache.org/jira/browse/HBASE-4778
Project: HBase
Issue Type: Bug
Reporter: Nicolas Spiegelberg
Assignee: Mikhail Bautin
Fix For: 0.94.0
We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4778) Don't ignore corrupt StoreFiles
when opening a region
Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148964#comment-13148964 ]
Nicolas Spiegelberg commented on HBASE-4778:
--------------------------------------------
Part of 89-fb to trunk port. See r1181594
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.94.0
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4778) Don't ignore corrupt StoreFiles
when opening a region
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150130#comment-13150130 ]
Hudson commented on HBASE-4778:
-------------------------------
Integrated in HBase-0.92 #131 (See [https://builds.apache.org/job/HBase-0.92/131/])
HBASE-4778 Don't ignore corrupt StoreFiles when opening a region
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4778.patch
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4778) Don't ignore corrupt StoreFiles when
opening a region
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4778:
---------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.94.0
>
> Attachments: HBASE-4778.patch
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4778) Don't ignore corrupt StoreFiles
when opening a region
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149980#comment-13149980 ]
Ted Yu commented on HBASE-4778:
-------------------------------
I agree.
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.94.0
>
> Attachments: HBASE-4778.patch
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4778) Don't ignore corrupt StoreFiles
when opening a region
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148965#comment-13148965 ]
Hadoop QA commented on HBASE-4778:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503468/HBASE-4778.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/237//console
This message is automatically generated.
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.94.0
>
> Attachments: HBASE-4778.patch
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4778) Don't ignore corrupt StoreFiles
when opening a region
Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149977#comment-13149977 ]
Nicolas Spiegelberg commented on HBASE-4778:
--------------------------------------------
@Ted: In this particular case, I think we ended up finding that HDFS wasn't reading truncated HFiles properly. Overall though, the idea is to prioritize data integrity & consistency over availability. We shouldn't be silently opening regions with missing data. We should instead understand why the data is missing. If someone wants to add a 'data.loss.acceptable' flag and allow this to happen, then that's fine.
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.94.0
>
> Attachments: HBASE-4778.patch
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4778) Don't ignore corrupt StoreFiles when
opening a region
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4778:
---------------------------------------
Attachment: HBASE-4778.patch
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.94.0
>
> Attachments: HBASE-4778.patch
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4778) Don't ignore corrupt StoreFiles
when opening a region
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150002#comment-13150002 ]
Ted Yu commented on HBASE-4778:
-------------------------------
+1 on patch.
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.94.0
>
> Attachments: HBASE-4778.patch
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4778) Don't ignore corrupt StoreFiles
when opening a region
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148991#comment-13148991 ]
Ted Yu commented on HBASE-4778:
-------------------------------
What are users expected to do after IOException fails region open ?
I assume such scenario happened at FB. It is nice to know the remedies.
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.94.0
>
> Attachments: HBASE-4778.patch
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4778) Don't ignore corrupt StoreFiles
when opening a region
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150220#comment-13150220 ]
Hudson commented on HBASE-4778:
-------------------------------
Integrated in HBase-TRUNK #2438 (See [https://builds.apache.org/job/HBase-TRUNK/2438/])
HBASE-4778 Don't ignore corrupt StoreFiles when opening a region
nspiegelberg :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4778.patch
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4778) Don't ignore corrupt StoreFiles when
opening a region
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4778:
---------------------------------------
Status: Patch Available (was: Open)
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.94.0
>
> Attachments: HBASE-4778.patch
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4778) Don't ignore corrupt StoreFiles when
opening a region
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4778:
-------------------------
Fix Version/s: 0.92.0
Committed to 0.92.
> Don't ignore corrupt StoreFiles when opening a region
> -----------------------------------------------------
>
> Key: HBASE-4778
> URL: https://issues.apache.org/jira/browse/HBASE-4778
> Project: HBase
> Issue Type: Bug
> Reporter: Nicolas Spiegelberg
> Assignee: Mikhail Bautin
> Fix For: 0.92.0, 0.94.0
>
> Attachments: HBASE-4778.patch
>
>
> We used to ignore StoreFiles that failed to open, which led to a situation when only a subset of regions was opened, and HBase did not return results to clients for the affected set of keys. This change makes sure we propagate IOExceptions coming from an attempt to open a StoreFile all the way up to HRegionServer.openRegion, where it will lead to a failure to open the whole region. This way we can avoid returning corrupt data to the application.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira