You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/06/29 12:02:24 UTC
Review Request 67783: Removed unused variable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67783/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Jan Schlicht.
Repository: mesos
Description
-------
While this does not seem an issue for some compilers, e.g.,
clang-7.0.0 diagnoses the unused variable.
Diffs
-----
src/tests/containerizer/docker_containerizer_tests.cpp 43105e59e6c8328ac32b365c8e5223aef1ae0d26
Diff: https://reviews.apache.org/r/67783/diff/1/
Testing
-------
`make check` (Linux, Windows)
Thanks,
Benjamin Bannier
Re: Review Request 67783: Removed unused variable.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67783/#review205570
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67783']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67783
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67783/logs/mesos-tests-stdout.log):
```
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (73 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (4240 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (4264 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (3879 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (3909 ms total)
[----------] Global test environment tear-down
[==========] 990 tests from 98 test cases ran. (1042941 ms total)
[ PASSED ] 986 tests.
[ FAILED ] 4 tests, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
[ FAILED ] DockerTest.ROOT_DOCKER_interface
[ FAILED ] DockerTest.ROOT_DOCKER_kill
[ FAILED ] DockerTest.ROOT_DOCKER_CheckPortResource
4 FAILED TESTS
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67783/logs/mesos-tests-stderr.log):
```
I0629 14:47:00.030179 2508 master.cpp:10900] Updating the state of task 2d2a4ae4-c657-4eec-a2af-5e8429b5582f of framework 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0629 14:47:00.030179 5744 slave.cpp:3939] Shutting down framework 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-0000
I0629 14:47:00.030179 5744 slave.cpp:6660] Shutting down executor '2d2a4ae4-c657-4eec-a2af-5e8429b5582f' of framework 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-0000 at executor(1)@192.10.1.9:62709
I0629 14:47:00.033185 5744 slave.cpp:931] Agent terminating
W0629 14:47:00.033185 5744 slave.cpp:3935] Ignoring shutdown framework 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-0000 because it is terminating
I0629 14:47:00.033185 2508 master.cpp:10999] Removing task 2d2a4ae4-c657-4eec-a2af-5e8429b5582f with resourceI0629 14:46:59.318893 13936 exec.cpp:162] Version: 1.7.0
I0629 14:46:59.343857 15108 exec.cpp:236] Executor registered on agent 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-S0
I0629 14:46:59.348873 13236 executor.cpp:182] Received SUBSCRIBED event
I0629 14:46:59.352872 13236 executor.cpp:186] Subscribed executor on windows-03.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0629 14:46:59.353874 13236 executor.cpp:182] Received LAUNCH event
I0629 14:46:59.358873 13236 executor.cpp:679] Starting task 2d2a4ae4-c657-4eec-a2af-5e8429b5582f
I0629 14:46:59.442854 13236 executor.cpp:499] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0629 14:46:59.992184 13236 executor.cpp:693] Forked command at 13788
I0629 14:47:00.034185 14888 exec.cpp:445] Executor asked to shutdown
I0629 14:47:00.035185 13236 executor.cpp:182] Received SHUTDOWN event
I0629 14:47:00.035185 13236 executor.cpp:796] Shutting down
I0629 14:47:00.035185 13236 executor.cpp:909] Sending SIGTERM to process tree at pid 13s cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-0000 on agent 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-S0 at slave(449)@192.10.1.9:62688 (windows-03.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0629 14:47:00.038185 2508 master.cpp:1330] Agent 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-S0 at slave(449)@192.10.1.9:62688 (windows-03.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0629 14:47:00.038185 2508 master.cpp:3340] Disconnecting agent 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-S0 at slave(449)@192.10.1.9:62688 (windows-03.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0629 14:47:00.038185 2508 master.cpp:3359] Deactivating agent 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-S0 at slave(449)@192.10.1.9:62688 (windows-03.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0629 14:47:00.039183 12560 hierarchical.cpp:346] Removed framework 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-0000
I0629 14:47:00.039183 12560 hierarchical.cpp:769] Agent 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-S0 deactivated
I0629 14:47:00.039183 9908 containerizer.cpp:2407] Destroying container 71f3f9c8-e474-4de5-8083-c8b1e654acdc in RUNNING state
I0629 14:47:00.040185 9908 containerizer.cpp:3021] Transitioning the state of container 71f3f9c8-e474-4de5-8083-c8b1e654acdc from RUNNING to DESTROYING
I0629 14:47:00.040185 9908 launcher.cpp:155] Asked to destroy container 71f3f9c8-e474-4de5-8083-c8b1e654acdc
I0629 14:47:00.157199 12560 containerizer.cpp:2860] Container 71f3f9c8-e474-4de5-8083-c8b1e654acdc has exited
I0629 14:47:00.187201 14316 master.cpp:1172] Master terminating
I0629 14:47:00.192188 12560 hierarchical.cpp:612] Removed agent 81cb27c5-1c76-4dd5-bcf6-b11f0c3b2bbc-S0
I0629 14:47:00.507201 6288 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On June 29, 2018, 12:02 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67783/
> -----------------------------------------------------------
>
> (Updated June 29, 2018, 12:02 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While this does not seem an issue for some compilers, e.g.,
> clang-7.0.0 diagnoses the unused variable.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 43105e59e6c8328ac32b365c8e5223aef1ae0d26
>
>
> Diff: https://reviews.apache.org/r/67783/diff/1/
>
>
> Testing
> -------
>
> `make check` (Linux, Windows)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67783: Removed unused variable.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67783/#review205571
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On June 29, 2018, 2:02 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67783/
> -----------------------------------------------------------
>
> (Updated June 29, 2018, 2:02 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While this does not seem an issue for some compilers, e.g.,
> clang-7.0.0 diagnoses the unused variable.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 43105e59e6c8328ac32b365c8e5223aef1ae0d26
>
>
> Diff: https://reviews.apache.org/r/67783/diff/1/
>
>
> Testing
> -------
>
> `make check` (Linux, Windows)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67783: Removed unused variable.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67783/#review205577
-----------------------------------------------------------
Ship it!
Thanks Ben!
- Andrew Schwartzmeyer
On June 29, 2018, 5:02 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67783/
> -----------------------------------------------------------
>
> (Updated June 29, 2018, 5:02 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While this does not seem an issue for some compilers, e.g.,
> clang-7.0.0 diagnoses the unused variable.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 43105e59e6c8328ac32b365c8e5223aef1ae0d26
>
>
> Diff: https://reviews.apache.org/r/67783/diff/1/
>
>
> Testing
> -------
>
> `make check` (Linux, Windows)
>
>
> Thanks,
>
> Benjamin Bannier
>
>