You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yujun777 (via GitHub)" <gi...@apache.org> on 2023/12/15 02:07:29 UTC
[PR] [improvement](publish version) publish txn fail retry do not sleep [doris]
yujun777 opened a new pull request, #28441:
URL: https://github.com/apache/doris/pull/28441
If many txns publish failed, each sleep 2s will cause txns start to pile up.
No need wait here, even if BE publish failed here, FE will send retry tasks later (no more than 15s).
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](publish version) publish txn fail retry do not wait 1s [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28441:
URL: https://github.com/apache/doris/pull/28441#issuecomment-1857175560
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 5b8115d98882632f2cce5108e1ffe627f1ab1b4d, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4727 4515 4451 4451
q2 365 146 159 146
q3 1460 1303 1238 1238
q4 1108 920 894 894
q5 3162 3167 3159 3159
q6 250 127 129 127
q7 984 494 478 478
q8 2228 2208 2178 2178
q9 6700 6664 6628 6628
q10 3223 3245 3261 3245
q11 328 198 211 198
q12 344 211 204 204
q13 4549 3814 3818 3814
q14 242 221 217 217
q15 561 527 528 527
q16 448 390 379 379
q17 994 550 573 550
q18 7114 7054 6935 6935
q19 1521 1396 1391 1391
q20 512 283 302 283
q21 3056 2614 2608 2608
q22 351 274 281 274
Total cold run time: 44227 ms
Total hot run time: 39924 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4428 4404 4414 4404
q2 272 161 171 161
q3 3521 3513 3514 3513
q4 2371 2352 2358 2352
q5 5726 5723 5738 5723
q6 240 122 119 119
q7 2390 1879 1841 1841
q8 3514 3513 3527 3513
q9 9018 8964 8995 8964
q10 3923 3987 3994 3987
q11 506 392 390 390
q12 767 589 592 589
q13 4286 3560 3580 3560
q14 284 261 265 261
q15 571 532 525 525
q16 508 448 467 448
q17 1863 1850 1835 1835
q18 8622 8353 8252 8252
q19 1726 1738 1712 1712
q20 2266 1952 1936 1936
q21 6511 6143 6119 6119
q22 499 432 412 412
Total cold run time: 63812 ms
Total hot run time: 60616 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](publish version) publish txn fail retry do not wait 1s [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28441:
URL: https://github.com/apache/doris/pull/28441#issuecomment-1857164225
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](publish version) publish txn fail retry do not wait 1s [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28441:
URL: https://github.com/apache/doris/pull/28441#issuecomment-1857221847
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.5 seconds
stream load tsv: 602 seconds loaded 74807831229 Bytes, about 118 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17222555462 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](publish version) publish txn fail retry do not sleep [doris]
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #28441:
URL: https://github.com/apache/doris/pull/28441#issuecomment-1857158479
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](publish version) publish txn fail retry do not wait 1s [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28441:
URL: https://github.com/apache/doris/pull/28441#issuecomment-1857271137
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 5b8115d98882632f2cce5108e1ffe627f1ab1b4d, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4722 4456 4460 4456
q2 372 142 139 139
q3 1466 1269 1218 1218
q4 1110 932 880 880
q5 3173 3234 3192 3192
q6 247 128 126 126
q7 1002 490 479 479
q8 2170 2189 2191 2189
q9 6689 6696 6616 6616
q10 3229 3283 3290 3283
q11 322 208 207 207
q12 357 210 210 210
q13 4567 3845 3816 3816
q14 238 214 209 209
q15 572 529 534 529
q16 440 396 385 385
q17 1024 641 597 597
q18 7101 6864 6836 6836
q19 1526 1449 1353 1353
q20 547 317 304 304
q21 3051 2660 2699 2660
q22 348 282 283 282
Total cold run time: 44273 ms
Total hot run time: 39966 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4378 4382 4395 4382
q2 265 163 168 163
q3 3501 3507 3501 3501
q4 2385 2375 2370 2370
q5 5725 5758 5752 5752
q6 237 123 122 122
q7 2388 1836 1868 1836
q8 3512 3530 3530 3530
q9 9056 8960 9023 8960
q10 3901 3999 3998 3998
q11 492 370 394 370
q12 773 585 606 585
q13 4282 3581 3539 3539
q14 294 256 255 255
q15 571 518 523 518
q16 492 449 487 449
q17 1857 1846 1839 1839
q18 8581 8129 8187 8129
q19 1819 1761 1758 1758
q20 2252 1965 1962 1962
q21 6466 6133 6106 6106
q22 502 420 432 420
Total cold run time: 63729 ms
Total hot run time: 60544 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](publish version) publish txn fail retry do not wait 1s [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28441:
URL: https://github.com/apache/doris/pull/28441#issuecomment-1857176682
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](publish version) publish txn fail retry do not wait 1s [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28441:
URL: https://github.com/apache/doris/pull/28441#issuecomment-1857163547
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](publish version) publish txn fail retry do not wait 1s [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #28441:
URL: https://github.com/apache/doris/pull/28441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org