You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Oliver Deakin <ol...@googlemail.com> on 2009/08/06 14:33:58 UTC
Re: [classlib] help wanted ... jclprots.h headers
Hi Mark,
Been a while but...
I just tried this out on Windows x86 with the default build options and
also specifying -Dhy.no.thr=true and it builds for me in both cases
successfully with an empty jclprots.h, so I think you are ok to go ahead
and remove this file and references.
Regards,
Oliver
Mark Hindess wrote:
> I'd like to remove the jclprots.h header files. These are enormous
> files that contain lots of prototypes. Their contents ignores any
> notion of modularity and they should be replaced by module headers or
> just local headers. There are some simple steps to remove them:
>
> 1) Truncate the unix header to 0 bytes.
> 2) Temporarily add -Wimplicit-function-declaration to defines.mk for
> unix build and run the build
> 3) Fix any errors - move declarations to more appropriate header files -
> and repeat 2) until it works.
> 4) .. 6) repeat for windows.
> 7) Remove all references to jclprots.h and the two header files.
>
> I've just check in r747597 with the changes for 1) ... 3) and was hoping
> someone could do the equivalent for windows so that I can do 7).
>
> Thanks in advance,
> Mark.
>
>
>
>
--
Oliver Deakin
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
BlueHornet
Posted by Mikołaj Roszak <en...@stargard.mm.pl>.
Mikołaj Roszak
----- Original Message -----
From: "Oliver Deakin" <ol...@googlemail.com>
To: <de...@harmony.apache.org>
Sent: Thursday, August 06, 2009 2:33 PM
Subject: Re: [classlib] help wanted ... jclprots.h headers
> Hi Mark,
>
> Been a while but...
>
> I just tried this out on Windows x86 with the default build options and
> also specifying -Dhy.no.thr=true and it builds for me in both cases
> successfully with an empty jclprots.h, so I think you are ok to go ahead
> and remove this file and references.
>
> Regards,
> Oliver
>
> Mark Hindess wrote:
>> I'd like to remove the jclprots.h header files. These are enormous
>> files that contain lots of prototypes. Their contents ignores any
>> notion of modularity and they should be replaced by module headers or
>> just local headers. There are some simple steps to remove them:
>>
>> 1) Truncate the unix header to 0 bytes.
>> 2) Temporarily add -Wimplicit-function-declaration to defines.mk for
>> unix build and run the build
>> 3) Fix any errors - move declarations to more appropriate header files -
>> and repeat 2) until it works.
>> 4) .. 6) repeat for windows.
>> 7) Remove all references to jclprots.h and the two header files.
>>
>> I've just check in r747597 with the changes for 1) ... 3) and was hoping
>> someone could do the equivalent for windows so that I can do 7).
>>
>> Thanks in advance,
>> Mark.
>>
>>
>>
>>
>
> --
> Oliver Deakin
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
> PO6 3AU
>
Re: [classlib] help wanted ... jclprots.h headers
Posted by Mark Hindess <ma...@googlemail.com>.
In message <4A...@googlemail.com>, Oliver Deakin writes:
>
> Hi Mark,
>
> Been a while but...
*yawn* *stretch* ... thanks for the quick response! ;-)
> I just tried this out on Windows x86 with the default build options and
> also specifying -Dhy.no.thr=true and it builds for me in both cases
> successfully with an empty jclprots.h, so I think you are ok to go ahead
> and remove this file and references.
Excellent. I'll make the changes to remove this completely shortly.
-Mark.
> Mark Hindess wrote:
> > I'd like to remove the jclprots.h header files. These are enormous
> > files that contain lots of prototypes. Their contents ignores any
> > notion of modularity and they should be replaced by module headers or
> > just local headers. There are some simple steps to remove them:
> >
> > 1) Truncate the unix header to 0 bytes.
> > 2) Temporarily add -Wimplicit-function-declaration to defines.mk for
> > unix build and run the build
> > 3) Fix any errors - move declarations to more appropriate header files -
> > and repeat 2) until it works.
> > 4) .. 6) repeat for windows.
> > 7) Remove all references to jclprots.h and the two header files.
> >
> > I've just check in r747597 with the changes for 1) ... 3) and was hoping
> > someone could do the equivalent for windows so that I can do 7).
> >
> > Thanks in advance,
> > Mark.
> >
> >
> >
> >
>
> --
> Oliver Deakin
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number 7415
> 98.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>