You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 14:26:50 UTC
[GitHub] [arrow] LouisClt opened a new pull request, #14208: Let ORC compile on MSVC if it is activated
LouisClt opened a new pull request, #14208:
URL: https://github.com/apache/arrow/pull/14208
Modify CmakeLists.txt so that it lets ORC compile if ARROW_ORC is defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1256623573
Could you apply this for AppVeyor job?
```diff
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1276995164
I've fixed CI failures on AppVeyor and GitHub Actions.
I'll merge this tomorrow if nobody objects it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] LouisClt commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
LouisClt commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1255897682
Hello, I made the changes you suggested. I don't know if this will compile fine as my only compile tests were with vcpkg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1255568295
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] LouisClt commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
LouisClt commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1256588631
I can try to fix them, at least for the easy ones. How's that these warnings did not fire before ? It is specific to Visual C++ ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1255568253
https://issues.apache.org/jira/browse/ARROW-17817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1255540391
Could you enable ORC in our CI jobs?
```diff
diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index 2642a6ec1a..07243ffc4e 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -213,6 +213,7 @@ jobs:
ARROW_HOME: /usr
ARROW_JEMALLOC: OFF
ARROW_MIMALLOC: ON
+ ARROW_ORC: ON
ARROW_PARQUET: ON
ARROW_USE_GLOG: OFF
ARROW_VERBOSE_THIRDPARTY_BUILD: OFF
diff --git a/ci/appveyor-cpp-build.bat b/ci/appveyor-cpp-build.bat
index 4b90e49257..d8eb9d2c11 100644
--- a/ci/appveyor-cpp-build.bat
+++ b/ci/appveyor-cpp-build.bat
@@ -68,6 +68,7 @@ cmake -G "%GENERATOR%" %CMAKE_ARGS% ^
-DARROW_FLIGHT_SQL=%ARROW_BUILD_FLIGHT_SQL% ^
-DARROW_GANDIVA=%ARROW_BUILD_GANDIVA% ^
-DARROW_MIMALLOC=ON ^
+ -DARROW_ORC=ON ^
-DARROW_PARQUET=ON ^
-DARROW_PYTHON=ON ^
-DARROW_S3=%ARROW_S3% ^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1279274014
Revision: f5ede2c962514c6f867f9a83adee755ec7a768b6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5f0a218feb](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5f0a218feb)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/3251759541/jobs/5337179797)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #14208:
URL: https://github.com/apache/arrow/pull/14208#discussion_r978992354
##########
ci/appveyor-cpp-build.bat:
##########
@@ -68,6 +68,7 @@ cmake -G "%GENERATOR%" %CMAKE_ARGS% ^
-DARROW_FLIGHT_SQL=%ARROW_BUILD_FLIGHT_SQL% ^
-DARROW_GANDIVA=%ARROW_BUILD_GANDIVA% ^
-DARROW_MIMALLOC=ON ^
+ -DARROW_ORC=ON
Review Comment:
```suggestion
-DARROW_ORC=ON ^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1256620505
I think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1279503666
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
kou merged PR #14208:
URL: https://github.com/apache/arrow/pull/14208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1281028550
Benchmark runs are scheduled for baseline = f0cf5c2033b99897d31c297f2cc116fa2689feec and contender = aeba61663fdd82719e6cc0945aba216958ad6970. aeba61663fdd82719e6cc0945aba216958ad6970 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/815f594e038046868bca63bf6f409381...5815c1a9e40d4d73811745f8a12be57e/)
[Failed :arrow_down:0.56% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3c13e83602df43b78fe32dd0e36e594d...0a83d7e7a45e4baaa392eb0cf497081c/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/193ef184b4134da6a49b4f38a6d8a583...73c2d0234e424cfb84fb668c644bbadd/)
[Finished :arrow_down:0.61% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/278453a4e69f4592bd3beaddd07ea18d...428cc867793647ce86a6503627c319e2/)
Buildkite builds:
[Finished] [`aeba6166` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1719)
[Failed] [`aeba6166` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1738)
[Finished] [`aeba6166` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1721)
[Finished] [`aeba6166` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1732)
[Finished] [`f0cf5c20` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1718)
[Failed] [`f0cf5c20` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1737)
[Finished] [`f0cf5c20` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1720)
[Finished] [`f0cf5c20` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1731)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] LouisClt commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
LouisClt commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1259073968
I made the changes for the AppVeyor job failure. However this still does not work because it can't find a correct version of protobuf (from looking at the logs).
There is also a problem in the "C++ / AMD64 Windows 2019 C++17" job, it seems it can't find some Zstd symbols during linking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1279051624
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1279505559
Revision: b7b3f6e4efcddabec55b682c58cb36d2dc501234
Submitted crossbow builds: [ursacomputing/crossbow @ actions-e1f7effb08](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e1f7effb08)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/3253173725/jobs/5340184047)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14208: ARROW-17817: [C++] Let ORC compile on MSVC if it is activated
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14208:
URL: https://github.com/apache/arrow/pull/14208#issuecomment-1281028939
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/3c13e83602df43b78fe32dd0e36e594d...0a83d7e7a45e4baaa392eb0cf497081c/)
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/193ef184b4134da6a49b4f38a6d8a583...73c2d0234e424cfb84fb668c644bbadd/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org