[GitHub] [incubator-echarts] pissang commented on issue #11484: Fix #11300

[GitBox <gi...@apache.org>]

pissang commented on issue #11484: Fix #11300
URL: https://github.com/apache/incubator-echarts/pull/11484#issuecomment-546182937
 
 
   Hi @susiwen8 .  
   
   I think the main cause is from https://github.com/apache/incubator-echarts/blob/master/src/coord/Axis.js#L88
   
   Current solution of `containData` will convert the data to coordinates, then verify if coordinates is between the axis extent. Some information will be lost during this conversion. Like coord will be clamped as you metioned in https://github.com/apache/incubator-echarts/issues/11300#issuecomment-536280273
   
   From my perspective, a better solution is using `Scale#contain` 
   
   ```js
   containData: function (data) {
     return this.scale.contain(data);
   }
   ```
   
   BTW: You can try using `cnpm` to install puppeteer. It will use Taobao Mirror to download the executable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org