[GitHub] [james-project] glennosss edited a comment on pull request #924: JAMES-3715 Migrates to Netty4

[GitBox <gi...@apache.org>]

glennosss edited a comment on pull request #924:
URL: https://github.com/apache/james-project/pull/924#issuecomment-1075816011


   [JAMES-3715 Improved failure messages on bind/unbind failures.](https://github.com/glennosss/james-project/commit/d648c57f3066f9d90f15f8001ae4d3c7944d7697)
   1. Wrap netty exception from different call stack - which netty is just blindly rethrowing in the new call stack. This issue is discussed more here: https://github.com/netty/netty/issues/2597
   2. On bind, set better failure message to promise that includes the address that caused the failure. Without this you just get 'java.net.BindException: Address already in use: bind'.
   3. Changed 'Future<?>' to 'Future<Void>' to cause less issues when manipulating futures (found situations where couldn't assign 'Future<?>' to another 'Future<?>').


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org