[GitHub] [incubator-superset] mistercrunch commented on issue #6403: Integrate Kepler.gl as a new visualization type

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #6403: Integrate Kepler.gl as a new visualization type
URL: https://github.com/apache/incubator-superset/pull/6403#issuecomment-481485586
 
 
   @heshan0131 I missed the notification on your previous comment, but thank you for your note! The main things I had questions around are:
   
   * are there any events I could hook onto when controls are changing? for now I had to hook up something to the `onSaveMap` event. Superset assumes that the visualization controls are outside the visualization, but passes a method to the visualization to allow it to change the value of a superset control. For now what I do is dump the state of Kepler inside a Superset TextControl, but we had to tell the users to go and push that button prior to saving... I wish I have a generic `onKeplerStateChange` prop or something like that...
   * is there a light style mode as opposed to the dark theme? I dug through the Kepler code and found some reference to a light theme, but it seemed to apply only to some modals... Maybe we just need a dark mode for Superset :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org