You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/12 13:16:46 UTC

[GitHub] [beam] iemejia edited a comment on pull request #13073: [BEAM-11055] Update log4j to version 2.13.3

iemejia edited a comment on pull request #13073:
URL: https://github.com/apache/beam/pull/13073#issuecomment-707110063


   > Do we really need to have so many places where the same version is defined? Couldn't be better to extract this into BeamModulePlugin.groovy since it's shared across different modules?
   
   I hesitated to do this because the references defined in `BeamModulePlugin.groovy` tend to be used as a reference of libraries Beam devs 'can' use and I did not want to promote the use of log4j which is not Beam's default logging library but mostly a provided lifetime one. If you prefer I can put it there. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org