You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sheng Yang <sh...@yasker.org> on 2014/05/14 00:31:56 UTC

[ACS44] Cherry pick for CLOUDSTACK-6241

Hi Daan,

Could you help to cherry pick the following commit to 4.4 branch?

commit d32f5c70d26ce82561bbdce962fd881a644ab81c
Author: Sheng Yang <sh...@citrix.com>
Date:   Fri Mar 14 13:36:43 2014 -0700

    CLOUDSTACK-6241: Fix default route for IPv6 network when IPv4 not used
    (cherry picked from commit e406adc0810b22ded0964080946f019be1337b52)

Thanks!

--Sheng

Re: [ACS44] Cherry pick for CLOUDSTACK-6241

Posted by Sheng Yang <sh...@yasker.org>.
It is "not equal".

When IPv4 is not set, no default route handling code would be processed.

--Sheng


On Wed, May 14, 2014 at 12:05 AM, Daan Hoogland <da...@gmail.com>wrote:

> On Wed, May 14, 2014 at 12:31 AM, Sheng Yang <sh...@yasker.org> wrote:
> > d32f5c70d26ce82561bbdce962fd881a644ab81c
>
>
> it's in
> but
>
> -if [ "$dflt" != "" ]
> +if [ "$dflt" != "" -a "$ipv4" != "" ]
>
> are you sure the comment is in line with the content?
> CLOUDSTACK-6241: Fix default route for IPv6 network when IPv4 not used
>
> would seem to suggest "$ipv4" == "" and not !=
>
> --
> Daan
>

Re: [ACS44] Cherry pick for CLOUDSTACK-6241

Posted by Daan Hoogland <da...@gmail.com>.
On Wed, May 14, 2014 at 12:31 AM, Sheng Yang <sh...@yasker.org> wrote:
> d32f5c70d26ce82561bbdce962fd881a644ab81c


it's in
but

-if [ "$dflt" != "" ]
+if [ "$dflt" != "" -a "$ipv4" != "" ]

are you sure the comment is in line with the content?
CLOUDSTACK-6241: Fix default route for IPv6 network when IPv4 not used

would seem to suggest "$ipv4" == "" and not !=

-- 
Daan