[GitHub] [griffin] guoyuepeng commented on a change in pull request #534: [GRIFFIN-290]Fix bug for submitting job to livy

[GitBox <gi...@apache.org>]

guoyuepeng commented on a change in pull request #534: [GRIFFIN-290]Fix bug for submitting job to livy
URL: https://github.com/apache/griffin/pull/534#discussion_r324217615
 
 

 ##########
 File path: service/src/main/java/org/apache/griffin/core/job/SparkSubmitJob.java
 ##########
 @@ -204,6 +204,7 @@ private void setLivyArgs() throws IOException {
         args.add(finalMeasureJson);
         args.add("raw,raw");
         livyConfMap.put("args", args);
+        livyConfMap.remove("name");
 
 Review comment:
   I agree to remove duplicated names. 
   But how should we handle the cases when users want to explicitly specify name by their job config? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services