You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/06/07 09:02:43 UTC
[GitHub] incubator-zeppelin pull request #972: ZEPPELIN-531 ] Jobmanagement - (1) bas...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/972
ZEPPELIN-531 ] Jobmanagement - (1) basic backend.
### What is this PR for?
Job management basic backend.
was divided into smaller " PR ". - https://github.com/apache/incubator-zeppelin/pull/921
Receive the basic data of Job manager api and the backend have been implemented.
### What type of PR is it?
Feature
### Todos
* [x] - Basic backend for job manager.
[x] - Basic backend api
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-531
### How should this be tested?
1. call command
```shell
curl -H "Content-Type: application/json" -X GET http://127.0.0.1:8080/api/notebook/jobmanager/
```
result
```json
{"status":"OK","body":{"lastResponseUnixTime":1465289938763,"jobs":[{"notebookId":"2BMQZ9QP6","unixTimeLastRun":1465289017310,"notebookType":"normal","isRunningJob":false,"notebookName":"Untitled Note 1226","interpreter":"spark","paragraphs":[{"name":"20160607-174331_232775609","id":"20160607-174331_232775609","status":"FINISHED"}]}]}}
```
2. recall - get updated job data.
**"lastResponseUnixTime": 1465289938763**
```shell
curl -H "Content-Type: application/json" -X GET http://127.0.0.1:8080/api/notebook/jobmanager/1465289938763
```
3. If there is a run or modify the notebook computer, information of the notebook PC must be output with respect to it.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin feat/sm/ZEPPELIN-531-basic-backend
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/972.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #972
----
commit c7bf75a4cbc28524dea2c9dce0f9f216fb827bb8
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-07T08:44:59Z
Jobmanager basic backend.
commit 330ed73cf8e0034cc80f45af9c8e62cbebe0a5bf
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-07T09:01:23Z
change indent for jobmanager backend
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #972: ZEPPELIN-531 ] Jobmanagement - (1) bas...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/972
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #972: ZEPPELIN-963 ] Jobmanagement - (1) basic back...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/972
Updated text for test scenario.
@astroshim
lastResponseUnixTime value is update data area key.
to query the Future updates based on LastResponseUnixTime value,
by updating continue this value, it is possible to acquire the data updated based on the lastResponseUnixTime.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #972: ZEPPELIN-531 ] Jobmanagement - (1) bas...
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/972
ZEPPELIN-531 ] Jobmanagement - (1) basic backend.
### What is this PR for?
Job management basic backend.
was divided into smaller " PR ". - https://github.com/apache/incubator-zeppelin/pull/921
Receive the basic data of Job manager api and the backend have been implemented.
### What type of PR is it?
Feature
### Todos
- [x] - Basic backend for job manager.
- [x] - Basic backend api
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-531
### How should this be tested?
1. call command
```shell
curl -H "Content-Type: application/json" -X GET http://127.0.0.1:8080/api/notebook/jobmanager/
```
result
```json
{"status":"OK","body":{"lastResponseUnixTime":1465289938763,"jobs":[{"notebookId":"2BMQZ9QP6","unixTimeLastRun":1465289017310,"notebookType":"normal","isRunningJob":false,"notebookName":"Untitled Note 1226","interpreter":"spark","paragraphs":[{"name":"20160607-174331_232775609","id":"20160607-174331_232775609","status":"FINISHED"}]}]}}
```
2. recall - get updated job data.
**"lastResponseUnixTime": 1465289938763**
```shell
curl -H "Content-Type: application/json" -X GET http://127.0.0.1:8080/api/notebook/jobmanager/1465289938763
```
3. If there is a run or modify the notebook computer, information of the notebook PC must be output with respect to it.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin feat/sm/ZEPPELIN-531-basic-backend
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/972.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #972
----
commit c7bf75a4cbc28524dea2c9dce0f9f216fb827bb8
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-07T08:44:59Z
Jobmanager basic backend.
commit 330ed73cf8e0034cc80f45af9c8e62cbebe0a5bf
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-07T09:01:23Z
change indent for jobmanager backend
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #972: ZEPPELIN-963 ] Jobmanagement - (1) basic back...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/972
Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #972: ZEPPELIN-963 ] Jobmanagement - (1) basic back...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/972
@astroshim
http://127.0.0.1:8080/api/notebook/jobmanager/(get unixtime at before step)
for example
http://127.0.0.1:8080/api/notebook/jobmanager/
(get unixtime is 1)
http://127.0.0.1:8080/api/notebook/jobmanager/1
(get unixtime is 2)
http://127.0.0.1:8080/api/notebook/jobmanager/2
....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #972: ZEPPELIN-531 ] Jobmanagement - (1) basic back...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/972
Thanks. Do you have any test scenario? It would help to add test cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #972: ZEPPELIN-531 ] Jobmanagement - (1) bas...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/972
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #972: ZEPPELIN-531 ] Jobmanagement - (1) bas...
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/972
ZEPPELIN-531 ] Jobmanagement - (1) basic backend.
### What is this PR for?
Job management basic backend.
was divided into smaller " PR ". - https://github.com/apache/incubator-zeppelin/pull/921
Receive the basic data of Job manager api and the backend have been implemented.
### What type of PR is it?
Feature
### Todos
- [x] - Basic backend for job manager.
- [x] - Basic backend api
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-531
### How should this be tested?
1. call command
```shell
curl -H "Content-Type: application/json" -X GET http://127.0.0.1:8080/api/notebook/jobmanager/
```
result
```json
{"status":"OK","body":{"lastResponseUnixTime":1465289938763,"jobs":[{"notebookId":"2BMQZ9QP6","unixTimeLastRun":1465289017310,"notebookType":"normal","isRunningJob":false,"notebookName":"Untitled Note 1226","interpreter":"spark","paragraphs":[{"name":"20160607-174331_232775609","id":"20160607-174331_232775609","status":"FINISHED"}]}]}}
```
2. recall - get updated job data.
**"lastResponseUnixTime": 1465289938763**
```shell
curl -H "Content-Type: application/json" -X GET http://127.0.0.1:8080/api/notebook/jobmanager/1465289938763
```
3. If there is a run or modify the notebook computer, information of the notebook PC must be output with respect to it.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin feat/sm/ZEPPELIN-531-basic-backend
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/972.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #972
----
commit c7bf75a4cbc28524dea2c9dce0f9f216fb827bb8
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-07T08:44:59Z
Jobmanager basic backend.
commit 330ed73cf8e0034cc80f45af9c8e62cbebe0a5bf
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-07T09:01:23Z
change indent for jobmanager backend
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #972: ZEPPELIN-531 ] Jobmanagement - (1) basic back...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/972
@jongyoul Thank you for your feedback.
I'll write about test scenario.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #972: ZEPPELIN-531 ] Jobmanagement - (1) basic back...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/972
retry ci
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #972: ZEPPELIN-963 ] Jobmanagement - (1) basic back...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/972
Update text for 'How should this be tested' and add json data comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #972: ZEPPELIN-963 ] Jobmanagement - (1) basic back...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/972
@cloverhearts Thank you for your explanation. You mean that the "LastResponseUnixTime" is for getting notebook information of lastest updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #972: ZEPPELIN-963 ] Jobmanagement - (1) basic back...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/972
It's working nicely.
but Is the correct behavior that the lastResponseUnixTime is increased whenever call the curl?
Then i can't understand what's the purpose of step 3. Could you tell me more detail?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #972: ZEPPELIN-963 ] Jobmanagement - (1) basic back...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/972
@jongyoul I've changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #972: ZEPPELIN-531 ] Jobmanagement - (1) basic back...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/972
How about changing this title to add ZEPPELIN-963?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---