You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/25 12:54:22 UTC
[GitHub] [skywalking-python] tom-pytel opened a new pull request, #227: Fix tornado socket == None
tom-pytel opened a new pull request, #227:
URL: https://github.com/apache/skywalking-python/pull/227
Sometimes `socket` here is none, like when processing happens after connection has been closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel commented on pull request #227: Fix tornado socket == None
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on PR #227:
URL: https://github.com/apache/skywalking-python/pull/227#issuecomment-1194079789
Can't merge due to dead link checker failed, and running it again doesn't fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel commented on pull request #227: Fix tornado socket == None
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on PR #227:
URL: https://github.com/apache/skywalking-python/pull/227#issuecomment-1194014377
Umm ... old links or temporarily down?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #227: Fix tornado socket == None
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #227:
URL: https://github.com/apache/skywalking-python/pull/227#issuecomment-1194111415
When I clicked the file from https://github.com/apache/skywalking-python/tree/master/tests/plugin/http/sw_http, it works. Then refresh failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel merged pull request #227: Fix tornado socket == None
Posted by GitBox <gi...@apache.org>.
tom-pytel merged PR #227:
URL: https://github.com/apache/skywalking-python/pull/227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel commented on pull request #227: Fix tornado socket == None
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on PR #227:
URL: https://github.com/apache/skywalking-python/pull/227#issuecomment-1194111834
Now it let me merge, weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel commented on pull request #227: Fix tornado socket == None
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on PR #227:
URL: https://github.com/apache/skywalking-python/pull/227#issuecomment-1194110846
> This seems a GitHub issue?
Any way to force merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #227: Fix tornado socket == None
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #227:
URL: https://github.com/apache/skywalking-python/pull/227#issuecomment-1194109865
This seems a GitHub issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org