You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "wangning (Code Review)" <ge...@cloudera.org> on 2020/04/06 05:39:18 UTC
[kudu-CR] WIP allow skip block manager in some ops of local replica tools
wangning has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15656
Change subject: WIP allow skip block manager in some ops of local_replica tools
......................................................................
WIP allow skip block manager in some ops of local_replica tools
These cli ops could be speed up via skip opening block manager.
- local_replica cmeta print_replica_uuids
- local_replica cmeta rewrite_raft_config
- local_replica cmeta set_term
- local_replica dump wals
- local_replica list
Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 13 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/15656/1
--
To view, visit http://gerrit.cloudera.org:8080/15656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
Gerrit-Change-Number: 15656
Gerrit-PatchSet: 1
Gerrit-Owner: wangning <19...@gmail.com>
[kudu-CR] allow skip block manager in some ops of local replica tools
Posted by "wangning (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15656
to look at the new patch set (#2).
Change subject: allow skip block manager in some ops of local_replica tools
......................................................................
allow skip block manager in some ops of local_replica tools
These cli ops could be speed up via skip opening block manager.
- local_replica cmeta print_replica_uuids
- local_replica cmeta rewrite_raft_config
- local_replica cmeta set_term
- local_replica dump wals
- local_replica list
Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 13 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/15656/2
--
To view, visit http://gerrit.cloudera.org:8080/15656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
Gerrit-Change-Number: 15656
Gerrit-PatchSet: 2
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] allow skip block manager in some ops of local replica tools
Posted by "wangning (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15656
to look at the new patch set (#3).
Change subject: allow skip block manager in some ops of local_replica tools
......................................................................
allow skip block manager in some ops of local_replica tools
These cli ops could be speed up via skip opening block manager.
- local_replica cmeta print_replica_uuids
- local_replica cmeta rewrite_raft_config
- local_replica cmeta set_term
- local_replica dump wals
- local_replica list
Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 13 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/15656/3
--
To view, visit http://gerrit.cloudera.org:8080/15656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
Gerrit-Change-Number: 15656
Gerrit-PatchSet: 3
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] allow skip block manager in some ops of local replica tools
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15656 )
Change subject: allow skip block manager in some ops of local_replica tools
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
Gerrit-Change-Number: 15656
Gerrit-PatchSet: 3
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: wangning <19...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 18:52:38 +0000
Gerrit-HasComments: No
[kudu-CR] allow skip block manager in some ops of local replica tools
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15656 )
Change subject: allow skip block manager in some ops of local_replica tools
......................................................................
allow skip block manager in some ops of local_replica tools
These cli ops could be speed up via skip opening block manager.
- local_replica cmeta print_replica_uuids
- local_replica cmeta rewrite_raft_config
- local_replica cmeta set_term
- local_replica dump wals
- local_replica list
Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
Reviewed-on: http://gerrit.cloudera.org:8080/15656
Tested-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 13 insertions(+), 10 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
Gerrit-Change-Number: 15656
Gerrit-PatchSet: 4
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: wangning <19...@gmail.com>
[kudu-CR] allow skip block manager in some ops of local replica tools
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15656 )
Change subject: allow skip block manager in some ops of local_replica tools
......................................................................
Patch Set 3: Verified+1
The test failures seem unrelated.
--
To view, visit http://gerrit.cloudera.org:8080/15656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
Gerrit-Change-Number: 15656
Gerrit-PatchSet: 3
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: wangning <19...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 18:50:19 +0000
Gerrit-HasComments: No
[kudu-CR] allow skip block manager in some ops of local replica tools
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15656 )
Change subject: allow skip block manager in some ops of local_replica tools
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15656/2/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
http://gerrit.cloudera.org:8080/#/c/15656/2/src/kudu/tools/tool_action_local_replica.cc@158
PS2, Line 158: unique_ptr<FsManager>* fs_manager, bool skip_block_manager
nit: per the guidance of the Google style guide, could you reverse the order of these arguments so the input parameter (skip_block_manager) is first?
>When ordering function parameters, put all input-only parameters before any output parameters. In particular, do not add new parameters to the end of the function just because they are new; place new input-only parameters before the output parameters.
from https://google.github.io/styleguide/cppguide.html#Output_Parameters
http://gerrit.cloudera.org:8080/#/c/15656/2/src/kudu/tools/tool_action_local_replica.cc@242
PS2, Line 242: (&fs_manager, true)
nit: for boolean arguments, to improve readability, would you mind inline-annotating the variable name?
E.g.
RETURN_NOT_OK(FsInit(&fs_manager, /*skip_block_manager*/true));
--
To view, visit http://gerrit.cloudera.org:8080/15656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
Gerrit-Change-Number: 15656
Gerrit-PatchSet: 2
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 06 Apr 2020 18:43:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] allow skip block manager in some ops of local replica tools
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: allow skip block manager in some ops of local_replica tools
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
Gerrit-Change-Number: 15656
Gerrit-PatchSet: 3
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: wangning <19...@gmail.com>
[kudu-CR] allow skip block manager in some ops of local replica tools
Posted by "wangning (Code Review)" <ge...@cloudera.org>.
wangning has posted comments on this change. ( http://gerrit.cloudera.org:8080/15656 )
Change subject: allow skip block manager in some ops of local_replica tools
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15656/2/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
http://gerrit.cloudera.org:8080/#/c/15656/2/src/kudu/tools/tool_action_local_replica.cc@158
PS2, Line 158: bool skip_block_manager, unique_ptr<FsManager>* fs_manager
> nit: per the guidance of the Google style guide, could you reverse the orde
Thx for point out, I will read about it
http://gerrit.cloudera.org:8080/#/c/15656/2/src/kudu/tools/tool_action_local_replica.cc@242
PS2, Line 242: (/*skip_block_manag
> nit: for boolean arguments, to improve readability, would you mind inline-a
Done
--
To view, visit http://gerrit.cloudera.org:8080/15656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
Gerrit-Change-Number: 15656
Gerrit-PatchSet: 3
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: wangning <19...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 02:12:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] allow skip block manager in some ops of local replica tools
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15656 )
Change subject: allow skip block manager in some ops of local_replica tools
......................................................................
Patch Set 3:
Thank you for the patch!
--
To view, visit http://gerrit.cloudera.org:8080/15656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01e22354fdb76596008cd0824e240d24a8f20099
Gerrit-Change-Number: 15656
Gerrit-PatchSet: 3
Gerrit-Owner: wangning <19...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: wangning <19...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Apr 2020 18:52:47 +0000
Gerrit-HasComments: No