You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2024/10/19 05:19:11 UTC
[Impala-ASF-CR] IMPALA-13287: Check overflow for bigint arithmetic
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21755 )
Change subject: IMPALA-13287: Check overflow for bigint arithmetic
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21755/2/testdata/workloads/functional-query/queries/QueryTest/overflow.test
File testdata/workloads/functional-query/queries/QueryTest/overflow.test:
http://gerrit.cloudera.org:8080/#/c/21755/2/testdata/workloads/functional-query/queries/QueryTest/overflow.test@14
PS2, Line 14: ---- QUERY: Bigint addition overflow
: select 9223372036854775807 + 1;
: ---- CATCH
: Bigint expression overflowed
: ====
: ---- QUERY: Bigint subtraction overflow
: select -9223372036854775808 - 1;
: ---- CATCH
: Bigint expression overflowed
: ====
: ---- QUERY: Bigint multiplication overflow
: # 4294967296 is 2^32
: select 4294967296 * 4294967296;
: ---- CATCH
: Bigint expression overflowed
: ====
Can you add these and non-overflow expression into expr-benchmark.cc, under BenchmarkArithmetic?
Please check how the number compares before and after changes.
--
To view, visit http://gerrit.cloudera.org:8080/21755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf22bef737caeab241ac3c708f43c5a72bb22350
Gerrit-Change-Number: 21755
Gerrit-PatchSet: 2
Gerrit-Owner: Xuebin Su <xs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Xuebin Su <xs...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Oct 2024 05:19:11 +0000
Gerrit-HasComments: Yes