You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/04 20:05:00 UTC
[jira] [Commented] (NIFI-5258) Improve handling of response headers
for consistent application
[ https://issues.apache.org/jira/browse/NIFI-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500787#comment-16500787 ]
ASF GitHub Bot commented on NIFI-5258:
--------------------------------------
GitHub user thenatog opened a pull request:
https://github.com/apache/nifi/pull/2759
NIFI-5258 - Changed addHeader to setHeader which stops X-Frame-Option…
…s being added twice to responses. Changed the way docs webapp is created to allow adding the X-Frame-Options header to docs resources too. Added test to check response header.
NIFI-5258 - Added unit test to check header returns as expected.
NIFI-5258 - Fixed * import.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [Y] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [Y] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [Y] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [Y] Is your initial contribution a single, squashed commit?
### For code changes:
- [Y] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [Y] Have you written or updated unit tests to verify your changes?
- [Y] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thenatog/nifi NIFI-5258-rebased
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2759.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2759
----
commit fccd392054c1c43ac61add9bd456ab6ede367693
Author: thenatog <th...@...>
Date: 2018-05-30T20:53:28Z
NIFI-5258 - Changed addHeader to setHeader which stops X-Frame-Options being added twice to responses. Changed the way docs webapp is created to allow adding the X-Frame-Options header to docs resources too. Added test to check response header.
NIFI-5258 - Added unit test to check header returns as expected.
NIFI-5258 - Fixed * import.
----
> Improve handling of response headers for consistent application
> ---------------------------------------------------------------
>
> Key: NIFI-5258
> URL: https://issues.apache.org/jira/browse/NIFI-5258
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.6.0
> Reporter: Andy LoPresto
> Assignee: Nathan Gough
> Priority: Minor
> Labels: http, response
>
> Some response headers are not set consistently (missing or duplicated) on the different web contexts. Enforce consistent behavior.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)