You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/10/11 22:03:03 UTC
[GitHub] [phoenix] yanxinyi commented on a change in pull request #1231: PHOENIX-5838 Add Histograms for Table level Metrics
yanxinyi commented on a change in pull request #1231:
URL: https://github.com/apache/phoenix/pull/1231#discussion_r726594484
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricPublisherSupplierFactory.java
##########
@@ -31,4 +31,5 @@
* Interface for UnRegistering Publisher Method
*/
void unregisterMetricProvider();
+
Review comment:
nit: remove the extra line. Given no changes in this file.
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricServiceResolver.java
##########
@@ -62,4 +62,5 @@ public MetricPublisherSupplierFactory instantiate(String classString) {
}
return metricSupplier;
}
+
Review comment:
nit: remove the extra line. Given no changes in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org