You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by GitBox <gi...@apache.org> on 2019/04/23 13:27:15 UTC

[GitHub] [hbase-native-client] ianbuss commented on a change in pull request #1: HBASE-22201 Fixing a number of issues with test cases

ianbuss commented on a change in pull request #1: HBASE-22201 Fixing a number of issues with test cases
URL: https://github.com/apache/hbase-native-client/pull/1#discussion_r277675451
 
 

 ##########
 File path: src/test/client-test.cc
 ##########
 @@ -47,6 +47,10 @@ using hbase::Table;
 using hbase::TestUtil;
 
 class ClientTest : public ::testing::Test {
+ protected:
+  ~ClientTest() override {
 
 Review comment:
   It's the C++ destructor; I put this in to make sure the first few tests didn't pollute the remaining ones but on reflection I probably should have overridden the proper `TearDownTestCase` method in googletest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services