You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sriharsha Chintalapani <ha...@hortonworks.com> on 2017/05/22 20:51:55 UTC
Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT
configs in secure mode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
-----------------------------------------------------------
(Updated May 22, 2017, 8:51 p.m.)
Review request for Ambari and Alejandro Fernandez.
Repository: ambari
Description
-------
AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.
Diffs
-----
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml 1a5dde9c16
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 8b5c07dc90
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 5aa08c5369
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53a2a
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml b3d19d42e1
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 4a2a502a20
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836abb
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a29f74b668
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 8c659ee469
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 3054ca30c1
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 488562bf11
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 1610bb5580
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 1cdd184529
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14
ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63
Diff: https://reviews.apache.org/r/59459/diff/3/
Testing
-------
Thanks,
Sriharsha Chintalapani
Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT
configs in secure mode.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/#review175815
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml
Lines 52 (patched)
<https://reviews.apache.org/r/59459/#comment249150>
In order to change the value for existing clusters, will have to either change it during an Ambari Upgrade, i.e., UpgradeCatalog251.java
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
Lines 50 (patched)
<https://reviews.apache.org/r/59459/#comment249148>
Will need to call this same logic in the Storm Service Advisor for HDP 3.0
ambari-server/src/main/resources/stacks/stack_advisor.py
Lines 2866 (patched)
<https://reviews.apache.org/r/59459/#comment249142>
Just import re at the top
ambari-server/src/main/resources/stacks/stack_advisor.py
Lines 2873 (patched)
<https://reviews.apache.org/r/59459/#comment249145>
If we want to preserve order, then we should append to klass_array only if it doesn't already exist in some set, as opposed to doing set(klass_array)
ambari-server/src/main/resources/stacks/stack_advisor.py
Lines 2876 (patched)
<https://reviews.apache.org/r/59459/#comment249146>
This will append a "," even if no elements follow it.
Instead, use
klass_list = ["'" + e + "'" for e in klass_set]
updated_yaml_string = "[" + ",".join(klass_list) + "]"
ambari-server/src/main/resources/stacks/stack_advisor.py
Lines 2881 (patched)
<https://reviews.apache.org/r/59459/#comment249147>
Similar comment regarding the comma
- Alejandro Fernandez
On May 23, 2017, 4:58 p.m., Sriharsha Chintalapani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59459/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 4:58 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml 1a5dde9c16
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 8b5c07dc90
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 5aa08c5369
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53a2a
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml b3d19d42e1
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 4a2a502a20
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836abb
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a29f74b668
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 8c659ee469
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 3054ca30c1
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 488562bf11
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 1610bb5580
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 1cdd184529
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14
> ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63
>
>
> Diff: https://reviews.apache.org/r/59459/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriharsha Chintalapani
>
>
Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT
configs in secure mode.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/#review175861
-----------------------------------------------------------
Ship it!
Can submit changes for trunk in separate patch.
May have to check UpgradeCatalog251Test.java
- Alejandro Fernandez
On May 23, 2017, 9:16 p.m., Sriharsha Chintalapani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59459/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 9:16 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java 9255daf76b
> ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml 1a5dde9c16
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 8b5c07dc90
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 5aa08c5369
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53a2a
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml b3d19d42e1
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 4a2a502a20
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836abb
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a29f74b668
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 8c659ee469
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 3054ca30c1
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 488562bf11
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 1610bb5580
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 1cdd184529
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14
> ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63
>
>
> Diff: https://reviews.apache.org/r/59459/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriharsha Chintalapani
>
>
Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT
configs in secure mode.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/#review175878
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On May 23, 2017, 11:14 p.m., Sriharsha Chintalapani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59459/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 11:14 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java 40fafb21a87bf01fce7088ce43d06ab8af809522
> ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml 1a5dde9c16defc04377a8c171d6081a757f99a36
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml d8e2d7d7532b90df3ee9f65d13f6a90fe78da9cc
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml ca3c19358a66ea64659f8b57cb88be8eb093cfc2
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml cf2c2574da078d03ad0e29bb059a8446dea5f493
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 83a0a1eddf11ca20a066a1a8b9fdb4f9ebe16f39
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 6e899ee18f13ede38b60a920788acfe7f10c51dd
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 4e14e83bd653499339e64d430a20bebdca2951af
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 483a19497a956f7683bb17c0dd5e38b9e0f53f97
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml befc38bd078b719cb517a3ee7a885d6dddf9f9b7
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 3054ca30c19b6a46060fb30d8852f0af4f854fcc
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 9cd4acffe68b5a2fe17a1074574e9d7e7091038c
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 1610bb5580b5f17c0d642d74caf0f9e04a0d8b8b
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 1cdd18452902b911dd24971e00885f53a05e4bd6
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14f6333b4bbf2b71738bf683bde8122c
> ambari-server/src/main/resources/stacks/stack_advisor.py e393b9cbd9747330a7a8cab8acc40268e1fd6607
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java 862ab6e46d38a07032ee69381f4f4dd300819706
>
>
> Diff: https://reviews.apache.org/r/59459/diff/9/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriharsha Chintalapani
>
>
Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT
configs in secure mode.
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
-----------------------------------------------------------
(Updated May 23, 2017, 11:14 p.m.)
Review request for Ambari and Alejandro Fernandez.
Repository: ambari
Description
-------
AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java 40fafb21a87bf01fce7088ce43d06ab8af809522
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml 1a5dde9c16defc04377a8c171d6081a757f99a36
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml d8e2d7d7532b90df3ee9f65d13f6a90fe78da9cc
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml ca3c19358a66ea64659f8b57cb88be8eb093cfc2
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml cf2c2574da078d03ad0e29bb059a8446dea5f493
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 83a0a1eddf11ca20a066a1a8b9fdb4f9ebe16f39
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 6e899ee18f13ede38b60a920788acfe7f10c51dd
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 4e14e83bd653499339e64d430a20bebdca2951af
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 483a19497a956f7683bb17c0dd5e38b9e0f53f97
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml befc38bd078b719cb517a3ee7a885d6dddf9f9b7
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 3054ca30c19b6a46060fb30d8852f0af4f854fcc
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 9cd4acffe68b5a2fe17a1074574e9d7e7091038c
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 1610bb5580b5f17c0d642d74caf0f9e04a0d8b8b
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 1cdd18452902b911dd24971e00885f53a05e4bd6
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14f6333b4bbf2b71738bf683bde8122c
ambari-server/src/main/resources/stacks/stack_advisor.py e393b9cbd9747330a7a8cab8acc40268e1fd6607
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java 862ab6e46d38a07032ee69381f4f4dd300819706
Diff: https://reviews.apache.org/r/59459/diff/9/
Changes: https://reviews.apache.org/r/59459/diff/8-9/
Testing
-------
Thanks,
Sriharsha Chintalapani
Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT
configs in secure mode.
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
-----------------------------------------------------------
(Updated May 23, 2017, 9:16 p.m.)
Review request for Ambari and Alejandro Fernandez.
Repository: ambari
Description
-------
AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java 9255daf76b
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml 1a5dde9c16
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 8b5c07dc90
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 5aa08c5369
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53a2a
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml b3d19d42e1
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 4a2a502a20
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836abb
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a29f74b668
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 8c659ee469
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 3054ca30c1
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 488562bf11
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 1610bb5580
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 1cdd184529
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14
ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63
Diff: https://reviews.apache.org/r/59459/diff/8/
Changes: https://reviews.apache.org/r/59459/diff/7-8/
Testing
-------
Thanks,
Sriharsha Chintalapani
Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT
configs in secure mode.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/#review175847
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/stack_advisor.py
Line 2873 (original), 2872 (patched)
<https://reviews.apache.org/r/59459/#comment249175>
Need to declare this,
in the try block after klass_set = ...
klass_list = [("'" + e + "'") for e in klass_set]
In the exception handler,
klass_list = [("'" + e + "'") for e in list_classes]
- Alejandro Fernandez
On May 23, 2017, 8:32 p.m., Sriharsha Chintalapani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59459/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 8:32 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java 9255daf76b
> ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml 1a5dde9c16
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 8b5c07dc90
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 5aa08c5369
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53a2a
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml b3d19d42e1
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 4a2a502a20
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836abb
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a29f74b668
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 8c659ee469
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 3054ca30c1
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 488562bf11
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 1610bb5580
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 1cdd184529
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14
> ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63
>
>
> Diff: https://reviews.apache.org/r/59459/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriharsha Chintalapani
>
>
Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT
configs in secure mode.
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
-----------------------------------------------------------
(Updated May 23, 2017, 8:32 p.m.)
Review request for Ambari and Alejandro Fernandez.
Repository: ambari
Description
-------
AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java 9255daf76b
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml 1a5dde9c16
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 8b5c07dc90
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 5aa08c5369
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53a2a
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml b3d19d42e1
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 4a2a502a20
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836abb
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a29f74b668
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 8c659ee469
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 3054ca30c1
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 488562bf11
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 1610bb5580
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 1cdd184529
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14
ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63
Diff: https://reviews.apache.org/r/59459/diff/7/
Changes: https://reviews.apache.org/r/59459/diff/6-7/
Testing
-------
Thanks,
Sriharsha Chintalapani
Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT
configs in secure mode.
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
-----------------------------------------------------------
(Updated May 23, 2017, 4:58 p.m.)
Review request for Ambari and Alejandro Fernandez.
Repository: ambari
Description
-------
AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml 1a5dde9c16
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 8b5c07dc90
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 5aa08c5369
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53a2a
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml b3d19d42e1
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 4a2a502a20
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836abb
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a29f74b668
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 8c659ee469
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 3054ca30c1
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 488562bf11
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 1610bb5580
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 1cdd184529
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14
ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63
Diff: https://reviews.apache.org/r/59459/diff/6/
Changes: https://reviews.apache.org/r/59459/diff/5-6/
Testing
-------
Thanks,
Sriharsha Chintalapani
Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT
configs in secure mode.
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
-----------------------------------------------------------
(Updated May 23, 2017, 4:49 p.m.)
Review request for Ambari and Alejandro Fernandez.
Repository: ambari
Description
-------
AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml 1a5dde9c16
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 8b5c07dc90
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 5aa08c5369
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53a2a
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml b3d19d42e1
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 4a2a502a20
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836abb
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a29f74b668
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 8c659ee469
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 3054ca30c1
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 488562bf11
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 1610bb5580
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 1cdd184529
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14
ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63
Diff: https://reviews.apache.org/r/59459/diff/5/
Changes: https://reviews.apache.org/r/59459/diff/4-5/
Testing
-------
Thanks,
Sriharsha Chintalapani
Re: Review Request 59459: AMBARI-21045. Enable Storm's AutoTGT
configs in secure mode.
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59459/
-----------------------------------------------------------
(Updated May 23, 2017, 3:37 a.m.)
Review request for Ambari and Alejandro Fernandez.
Repository: ambari
Description
-------
AMBARI-21045. Enable Storm's AutoTGT configs in secure mode.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml 1a5dde9c16
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 8b5c07dc90
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 5aa08c5369
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53a2a
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml b3d19d42e1
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 4a2a502a20
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836abb
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml a29f74b668
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 8c659ee469
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 3054ca30c1
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 488562bf11
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 1610bb5580
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml 1cdd184529
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 3e7e3d7f14
ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63
Diff: https://reviews.apache.org/r/59459/diff/4/
Changes: https://reviews.apache.org/r/59459/diff/3-4/
Testing
-------
Thanks,
Sriharsha Chintalapani