[buildstream] 02/02: scriptelement.py: Don't mark layout locations as read-write directories

[ju...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

juergbi pushed a commit to branch juerg/layout-directories
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit 0dafa5a4e47812adaf2e2414255fff904230ee57
Author: Jürg Billeter <j...@bitron.ch>
AuthorDate: Fri Jul 8 10:29:41 2022 +0200

    scriptelement.py: Don't mark layout locations as read-write directories
    
    `mark_directory()` was originally called on layout locations to enable
    SafeHardlinks to protect the CAS cache from corruption. This is no
    longer relevant.
    
    This prevents the root directory of the sandbox from accidentally being
    marked as REAPI output directory, avoiding expensive capture operations.
---
 src/buildstream/scriptelement.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/buildstream/scriptelement.py b/src/buildstream/scriptelement.py
index 53f9e6103..514cd4101 100644
--- a/src/buildstream/scriptelement.py
+++ b/src/buildstream/scriptelement.py
@@ -207,10 +207,6 @@ class ScriptElement(Element):
         # Mark the install root
         sandbox.mark_directory(self.__install_root)
 
-        # Mark the artifact directories in the layout
-        for location in self.__layout:
-            sandbox.mark_directory(location)
-
     def stage(self, sandbox):
 
         # If self.layout_add() was never called, do the default staging of