You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/03/02 19:38:38 UTC

[PR] Minor: simplify call [arrow-datafusion]

alamb opened a new pull request, #9434:
URL: https://github.com/apache/arrow-datafusion/pull/9434

   ## Which issue does this PR close?
   
   Related to https://github.com/apache/arrow-datafusion/pull/9304 
   
   ## Rationale for this change
   
   While working on https://github.com/apache/arrow-datafusion/pull/9304 I noticed some code that was overly complicated to call a function. This was confusing and I would like to remove the rough edge
   ## What changes are included in this PR?
   Just call function with a reference without explicitly naming the clone method
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor: simplify call [arrow-datafusion]

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #9434:
URL: https://github.com/apache/arrow-datafusion/pull/9434


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org