[jira] [Work logged] (TRAFODION-3256) Missing error return in Statement::doHiveTableSimCheck

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TRAFODION-3256?focusedWorklogId=185419&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185419 ]

ASF GitHub Bot logged work on TRAFODION-3256:
---------------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Jan/19 20:34
            Start Date: 15/Jan/19 20:34
    Worklog Time Spent: 10m 
      Work Description: DaveBirdsall commented on pull request #1772: [TRAFODION-3256] Fix error path in CLI similarity check code
URL: https://github.com/apache/trafodion/pull/1772
 
 
   Add missing "return ERROR" (and an NADELETEBASIC to avoid memory leak) in method Statement::doHiveTableSimCheck.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 185419)
            Time Spent: 10m
    Remaining Estimate: 0h

> Missing error return in Statement::doHiveTableSimCheck
> ------------------------------------------------------
>
>                 Key: TRAFODION-3256
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-3256
>             Project: Apache Trafodion
>          Issue Type: Bug
>          Components: sql-exe
>    Affects Versions: 2.4
>            Reporter: David Wayne Birdsall
>            Assignee: David Wayne Birdsall
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> [https://github.com/apache/trafodion/pull/1766] rewrote much of Statement::doHiveTableSimCheck (cli/Statement.cpp). In one of the error cases, an 8577 error is raised but the method still returns SUCCESS. That can cause an infinite loop in the caller, Statement::execute. This error path should contain a "return ERROR" statement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)