You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/07/15 14:56:43 UTC

[GitHub] [commons-vfs] marcwrobel opened a new pull request, #277: Fix typos in code

marcwrobel opened a new pull request, #277:
URL: https://github.com/apache/commons-vfs/pull/277

   Fix various typos in code :
   
   - private field or constant names,
   - method attribute names,
   - test class and method names,
   - exception messages.
   
   Those changes should not be problematic : they do not belog to the public API (except maybe the exception messages).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] garydgregory merged pull request #277: Fix typos in code

Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #277:
URL: https://github.com/apache/commons-vfs/pull/277


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] marcwrobel commented on pull request #277: (chore) Fix typos in code

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #277:
URL: https://github.com/apache/commons-vfs/pull/277#issuecomment-1185632018

   I also found a typo in `FileSelector#traverseDescendents`, but I have created a Jira issue for it (https://issues.apache.org/jira/browse/VFS-821).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] marcwrobel commented on pull request #277: (chore) Fix typos in code

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #277:
URL: https://github.com/apache/commons-vfs/pull/277#issuecomment-1185857184

   @garydgregory, you are welcome. Branch rebased against master and conflicts fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] marcwrobel commented on pull request #277: Fix typos in code

Posted by GitBox <gi...@apache.org>.
marcwrobel commented on PR #277:
URL: https://github.com/apache/commons-vfs/pull/277#issuecomment-1185628932

   Should I have created a Jira issue for that PR ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] garydgregory commented on pull request #277: (chore) Fix typos in code

Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #277:
URL: https://github.com/apache/commons-vfs/pull/277#issuecomment-1185763350

   @marcwrobel 
   Thank you for your PR. Please resolve conflicts with git master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-vfs] darkma773r commented on pull request #277: (chore) Fix typos in code

Posted by GitBox <gi...@apache.org>.
darkma773r commented on PR #277:
URL: https://github.com/apache/commons-vfs/pull/277#issuecomment-1185640100

   Hi, @marcwrobel. Thanks for the PR! IMO, these changes fall under the "trivial" category and so don't need their own Jira issue. On the other hand, we do need the VFS-821 issue you created since that change affects the public API.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org