You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/11 15:15:28 UTC
[GitHub] [skywalking-python] tom-pytel opened a new pull request #128: removed requests as required dependency
tom-pytel opened a new pull request #128:
URL: https://github.com/apache/skywalking-python/pull/128
Fix for #125
<!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #128: removed requests as required dependency
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #128:
URL: https://github.com/apache/skywalking-python/pull/128#issuecomment-877820530
> > Do we need
>
> A different communication method? If requests is license problematic then why not change to standard python lib if possible, one less dependency too. https://github.com/psf/requests/pull/5797. We just need their new release.
Sorry, it was a copy/paste issue. There is no issue. This dependency issue should be resolved from the upstream repo already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel commented on pull request #128: removed requests as required dependency
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #128:
URL: https://github.com/apache/skywalking-python/pull/128#issuecomment-877819485
So if you have nothing against it I will look into replacing requests with standard python lib urllib to do the connections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel commented on pull request #128: removed requests as required dependency
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #128:
URL: https://github.com/apache/skywalking-python/pull/128#issuecomment-877820297
> Do we need
A different communication method? If requests is license problematic then why not change to standard python lib if possible, one less dependency too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #128: removed requests as required dependency
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #128:
URL: https://github.com/apache/skywalking-python/pull/128#issuecomment-877820220
FYI @potiuk This has been reverted and kept optional only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng merged pull request #128: removed requests as required dependency
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #128:
URL: https://github.com/apache/skywalking-python/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] potiuk commented on pull request #128: removed requests as required dependency
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #128:
URL: https://github.com/apache/skywalking-python/pull/128#issuecomment-878466814
Correct. I mentioned that in my report. So this is right, it's not *necesssary* according to the ASF Policy (similarly in Airflow we have a lot of extras with `requests`) - the "optional" LGPL dependency is acceptable. But once the new version is out, I think it would be great to make it "minimal" version of requests - this way the LGPL dependency becomes optional even for optional dependencies ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 edited a comment on pull request #128: removed requests as required dependency
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #128:
URL: https://github.com/apache/skywalking-python/pull/128#issuecomment-878314622
Hey, I can see `requests` is not required dependency. https://github.com/apache/skywalking-python/blob/master/setup.py It’s in `http` extra dependency.
Sorry, you are right, mixup on my part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel commented on pull request #128: removed requests as required dependency
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #128:
URL: https://github.com/apache/skywalking-python/pull/128#issuecomment-878292335
Heads up, I just grabbed the latest master which should have this and #127 merged and this change is not present. `setup.py` still contains `requests` as a required dependency. Guessing merge with @127 list it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #128: removed requests as required dependency
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #128:
URL: https://github.com/apache/skywalking-python/pull/128#issuecomment-878314622
> Heads up, I just grabbed the latest master which should have this and #127 merged and this change is not present. `setup.py` still contains `requests` as a required dependency. Guessing merge with @127 list it?
Hey, I can see `requests` is not required dependency. https://github.com/apache/skywalking-python/blob/master/setup.py It’s in `http` extra dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org