You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/06 03:11:27 UTC
[GitHub] [apisix-dashboard] Baoyuantop commented on a diff in pull request #2422: fix: correct data type of filed Active.checks.active.https_verify_certificate
Baoyuantop commented on code in PR #2422:
URL: https://github.com/apache/apisix-dashboard/pull/2422#discussion_r866458433
##########
api/internal/core/entity/entity.go:
##########
@@ -133,7 +133,7 @@ type Active struct {
Host string `json:"host,omitempty"`
Port int `json:"port,omitempty"`
HTTPPath string `json:"http_path,omitempty"`
- HTTPSVerifyCertificate string `json:"https_verify_certificate,omitempty"`
+ HTTPSVerifyCertificate bool `json:"https_verify_certificate,omitempty"`
Review Comment:
Is this excess space?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org