You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by fjiang6 <gi...@git.apache.org> on 2014/08/25 00:00:54 UTC
[GitHub] spark pull request: [SPARK-3188][MLLIB]: Add Robust Regression Alg...
GitHub user fjiang6 opened a pull request:
https://github.com/apache/spark/pull/2110
[SPARK-3188][MLLIB]: Add Robust Regression Algorithm with Turkey bisquare (Biweight) function
Biweight Robust Regression including the test case and an example.
Passed the style checks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Huawei-Spark/spark fanjiang-robustregression
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2110.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2110
----
commit 6ca4a44a9e8bd3b9a9dbc3d15ba0b76d77c75faa
Author: yzhou2001 <ya...@huawei.com>
Date: 2014-08-14T23:26:36Z
Merge pull request #1 from apache/master
A merge of latest changes since creation
commit 41d65b749ca583a2452864578005a1b960d8b117
Author: Bo Meng <bo...@huawei.com>
Date: 2014-08-22T02:54:19Z
Merge branch 'master' of https://github.com/Huawei-Spark/spark
cessary,
commit f0571890522eb09d092f01e8b5a208d4849e56df
Author: fjiang6 <fj...@gmail.com>
Date: 2014-08-21T22:34:15Z
add example HuberRobustRegression.scala
commit 38c1b3c0f7dd2a6f62eae2fecb006495ffc8a064
Author: fanjiang <fa...@ebay.com>
Date: 2014-08-22T09:49:41Z
add new class HuberRobustGradient and RobustRegression.scala
commit ba49567719299eb90b8f7a3a3db7561a912a210f
Author: fjiang6 <fj...@gmail.com>
Date: 2014-08-24T01:34:14Z
add Robust Regression Algorithm with Turkey bisquare weight function (Biweight Estimates)
commit f4a84a3cb938b9917ca1faa5f173152eb9b01998
Author: fjiang6 <fj...@gmail.com>
Date: 2014-08-24T17:17:39Z
adjust Gradient
commit 5f9e03fd393992074edff0ccea48f4887f556578
Author: fjiang6 <fj...@gmail.com>
Date: 2014-08-24T21:15:48Z
adjust Robust Regression Algorithm with Turkey bisquare weight function …
commit c9cafb31b234791d9728d1c5e0d2084214b1c3b5
Author: fjiang6 <fj...@gmail.com>
Date: 2014-08-24T21:31:19Z
adjust Tukey bisquare (Biweight) function for Robust Regression
commit 07e0e78d28d198ef36910933d0e199d0d4fa91ec
Author: fjiang6 <fj...@gmail.com>
Date: 2014-08-24T21:42:32Z
to validate the code style
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3188][MLLIB]: Add Robust Regression Alg...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2110#issuecomment-53210719
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3188][MLLIB]: Add Robust Regression Alg...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2110#issuecomment-54698556
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19862/consoleFull) for PR 2110 at commit [`07e0e78`](https://github.com/apache/spark/commit/07e0e78d28d198ef36910933d0e199d0d4fa91ec).
* This patch **fails** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3188][MLLIB]: Add Robust Regression Alg...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2110#issuecomment-54695092
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19862/consoleFull) for PR 2110 at commit [`07e0e78`](https://github.com/apache/spark/commit/07e0e78d28d198ef36910933d0e199d0d4fa91ec).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3188][MLLIB]: Add Robust Regression Alg...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/2110#issuecomment-77870526
I think this contribution may have "timed out", along with https://github.com/apache/spark/pull/2096 . They're probably good implementations, but I am not clear if this will be taken forward to be part of Spark. In any event it doesn't merge and is not necessarily written for the new ML pipelines API. Does anyone else have an opinion on whether this should be closed out, or needs to be revived?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org