You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/10/16 23:47:59 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2766: [GOBBLIN-912]Enable TTL caching on Hive Metastore client connection

sv2000 commented on a change in pull request #2766: [GOBBLIN-912]Enable TTL caching on Hive Metastore client connection
URL: https://github.com/apache/incubator-gobblin/pull/2766#discussion_r335757613
 
 

 ##########
 File path: gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveMetastoreClientPool.java
 ##########
 @@ -59,6 +60,17 @@
 
   public static final String POOL_CACHE_TTL_MINUTES_KEY = "hive.metaStorePoolCache.ttl";
 
+  public static final String POOL_EVICTION_POLICY_CLASS_NAME = "org.apache.commons.pool2.impl.DefaultEvictionPolicy";
 
 Review comment:
   What is the behavior of this eviction policy? Can we add a javadoc to help user understand why we are using this eviction policy? Also, should this be configurable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services