You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2017/05/30 18:07:17 UTC
Review Request 59642: GEODE-3000: do not have jetty log at debug level
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59642/
-----------------------------------------------------------
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-3000: do not have jetty log at debug level
Diffs
-----
geode-core/src/main/resources/log4j2.xml cdb932b5b3b3337aae4a6cde9800ebd5617a0c4d
geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/59642/diff/1/
Testing
-------
manual tests and precheckin running
Thanks,
Jinmei Liao
Re: Review Request 59642: GEODE-3000: do not have jetty log at debug
level
Posted by Emily Yeh <ey...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59642/#review176493
-----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
Lines 55-59 (patched)
<https://reviews.apache.org/r/59642/#comment249848>
Perhaps the Scanner should be closed? Just adding `scanner.close()` after the while loop should do it. (Alternatively, scanner could be instantiated before the `for` loop, so that it doesn't have to be re-instantiated during every iteration.)
- Emily Yeh
On May 31, 2017, 5:45 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59642/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 5:45 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3000: do not have jetty log at debug level
>
>
> Diffs
> -----
>
> geode-core/src/main/resources/log4j2.xml cdb932b5b3b3337aae4a6cde9800ebd5617a0c4d
> geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59642/diff/1/
>
>
> Testing
> -------
>
> precheckin successful
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 59642: GEODE-3000: do not have jetty log at debug
level
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59642/
-----------------------------------------------------------
(Updated May 31, 2017, 5:45 p.m.)
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
Repository: geode
Description
-------
GEODE-3000: do not have jetty log at debug level
Diffs
-----
geode-core/src/main/resources/log4j2.xml cdb932b5b3b3337aae4a6cde9800ebd5617a0c4d
geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/59642/diff/1/
Testing (updated)
-------
precheckin successful
Thanks,
Jinmei Liao
Re: Review Request 59642: GEODE-3000: do not have jetty log at debug
level
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59642/#review176378
-----------------------------------------------------------
Ship it!
Ship It!
- Ken Howe
On May 30, 2017, 6:07 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59642/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 6:07 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3000: do not have jetty log at debug level
>
>
> Diffs
> -----
>
> geode-core/src/main/resources/log4j2.xml cdb932b5b3b3337aae4a6cde9800ebd5617a0c4d
> geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59642/diff/1/
>
>
> Testing
> -------
>
> manual tests and precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 59642: GEODE-3000: do not have jetty log at debug
level
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59642/#review176322
-----------------------------------------------------------
Ship it!
Ship It!
- Jared Stewart
On May 30, 2017, 6:07 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59642/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 6:07 p.m.)
>
>
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-3000: do not have jetty log at debug level
>
>
> Diffs
> -----
>
> geode-core/src/main/resources/log4j2.xml cdb932b5b3b3337aae4a6cde9800ebd5617a0c4d
> geode-core/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59642/diff/1/
>
>
> Testing
> -------
>
> manual tests and precheckin running
>
>
> Thanks,
>
> Jinmei Liao
>
>