You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/31 07:43:12 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32558: [SPARK-34953][CORE][SQL] Add the code change for adding the DateType in the infer schema while reading in CSV and JSON

HyukjinKwon commented on a change in pull request #32558:
URL: https://github.com/apache/spark/pull/32558#discussion_r642281798



##########
File path: docs/sql-data-sources-json.md
##########
@@ -155,6 +155,12 @@ Data source options of JSON can be set via:
     <td>Allows leading zeros in numbers (e.g. 00012). If None is set, it uses the default value, <code>false</code>.</td>
     <td>read</td>
   </tr>
+  <tr>
+    <td><code>inferDateType</code></td>
+    <td>None</td>

Review comment:
       Let's change the default value to `false`. This was a mistake from https://github.com/apache/spark/pull/32204, and @itholic is working on it to fix. BTW, seems like CSV option is missing here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org