You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/30 20:37:56 UTC
[GitHub] [airflow] potiuk opened a new pull request, #27387: Fix selective checks to run all python version tests on env change
potiuk opened a new pull request, #27387:
URL: https://github.com/apache/airflow/pull/27387
Selective checks for "environment files" changed had a small problem, where images were built for all python versions (all-python-versions) but tests were not run (python-versions). The "all" variant is foreseen for case where we have different set of Python versions in main and different in v2* branch.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #27387: Fix selective checks to run all python version tests on env change
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on code in PR #27387:
URL: https://github.com/apache/airflow/pull/27387#discussion_r1010322011
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -306,7 +306,7 @@ def full_tests_needed(self) -> bool:
def python_versions(self) -> list[str]:
return (
CURRENT_PYTHON_MAJOR_MINOR_VERSIONS
- if self.full_tests_needed
+ if self._run_everything or self.full_tests_needed
Review Comment:
It seems that `_run_everything` already checks for `self.full_tests_needed`. Is is or condition necessary ?
Same question for `all_python_versions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #27387: Fix selective checks to run all python version tests on env change
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #27387:
URL: https://github.com/apache/airflow/pull/27387#discussion_r1010359284
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -306,7 +306,7 @@ def full_tests_needed(self) -> bool:
def python_versions(self) -> list[str]:
return (
CURRENT_PYTHON_MAJOR_MINOR_VERSIONS
- if self.full_tests_needed
+ if self._run_everything or self.full_tests_needed
Review Comment:
This is to handle the case where "run_everything = True" but "full_tests_needed = False" :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #27387: Fix selective checks to run all python version tests on env change
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27387:
URL: https://github.com/apache/airflow/pull/27387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org