You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/25 02:01:20 UTC

[jira] [Commented] (EAGLE-498) overwrite equals method for PolicyDefinition should not contain field description

    [ https://issues.apache.org/jira/browse/EAGLE-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436121#comment-15436121 ] 

ASF GitHub Bot commented on EAGLE-498:
--------------------------------------

GitHub user chitin opened a pull request:

    https://github.com/apache/incubator-eagle/pull/384

    EAGLE-498 overwrite equals method for PolicyDefinition should not con…

    EAGLE-498 overwrite equals method for PolicyDefinition should not contain field description
    
    - Delete the equals for description in method equals.
    - Delete append description in method hashCode.
    
    https://issues.apache.org/jira/browse/EAGLE-498

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chitin/incubator-eagle EAGLE498

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #384
    
----
commit 8fe8ac4fe7d5465ecb692aa0a63ea7c5b78292c8
Author: chitin <ch...@gmail.com>
Date:   2016-08-25T01:54:09Z

    EAGLE-498 overwrite equals method for PolicyDefinition should not contain field description
    - Delete the equals for description in method equals
    - Delete append description in method hashCode
    
    https://issues.apache.org/jira/browse/EAGLE-498

----


> overwrite equals method for PolicyDefinition should not contain field description
> ---------------------------------------------------------------------------------
>
>                 Key: EAGLE-498
>                 URL: https://issues.apache.org/jira/browse/EAGLE-498
>             Project: Eagle
>          Issue Type: Improvement
>            Reporter: Lingang Deng
>            Assignee: Lingang Deng
>            Priority: Trivial
>
> Overwrite equals method for PolicyDefinition should not contain field "description", it cause NullPointerException if"description": null in json file when I do unit test, and it is a descriptive field also.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)