[jira] [Commented] (TS-1079) Add an API function to turn debugging on for specific transactions/sessions

["Uri Shachar (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227035#comment-13227035 ] 

Uri Shachar commented on TS-1079:
---------------------------------

Patch includes a 'not pretty' macro in HttpSM.cc/HttpTransact.cc/HttpClientSession.cc to make debug lines shorter. It would be a lot prettier if we didn't have to support all sorts of compilers -- doing something like:
{code:title=HttpSM.cc|borderStyle=solid}
#define DebugSM(tag, format, ...) DebugSpecific(debug_on, tag, "[%" PRId64 "] "format, sm_id, ##__VA_ARGS__)
{code} 
Would look nicer and ensure debug lines are more consistent -- but isn't possible without a whole bunch of ifdefs when trying to support a lot of different compilers.
Maybe I should raise this in the mailing list...
/rant
                
> Add an API function to turn debugging on for specific transactions/sessions
> ---------------------------------------------------------------------------
>
>                 Key: TS-1079
>                 URL: https://issues.apache.org/jira/browse/TS-1079
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core, HTTP
>            Reporter: Uri Shachar
>            Priority: Minor
>             Fix For: 3.1.6
>
>         Attachments: debug_specific.patch, debug_specific_2.patch
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
>       When attempting to troubleshoot issues on a production ATS system, it is often impossible/difficult to turn on any of the 'high-volume' debug tags like http due to the performance impact.
>  
> This enhancement allows a plugin to set a debug flag for a specific txn/ssn, and replaces some of the internal Debug calls with a new function that checks if the flag is turned on, and outputs the debug line regardless of the tag if it is (The diags enable/disable flag is still taken into account).
> The API will also have TSDebugSpecific in order to allow plugins to use the same functionality.
> In addition, we might consider adding an internal config file (remap-like) to allow turning this flag on without plugin intervention.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira