You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/15 05:08:21 UTC
[GitHub] [arrow-datafusion] hntd187 opened a new pull request #1451: All building execution context from another execution context's state
hntd187 opened a new pull request #1451:
URL: https://github.com/apache/arrow-datafusion/pull/1451
# Which issue does this PR close?
Closes #1439
# Rationale for this change
See issue, but this allows a way to carry over current state to newly created execution contextes
# What changes are included in this PR?
Changes to carry over execution conext
# Are there any user-facing changes?
Not really
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #1451: All building execution context from another execution context's state
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #1451:
URL: https://github.com/apache/arrow-datafusion/pull/1451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1451: All building execution context from another execution context's state
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1451:
URL: https://github.com/apache/arrow-datafusion/pull/1451#issuecomment-995241146
I think `ExecutionContext` does implement clone:
```rust
#[derive(Clone)]
pub struct ExecutionContext {
/// Internal state for the context
pub state: Arc<Mutex<ExecutionContextState>>,
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] hntd187 commented on pull request #1451: All building execution context from another execution context's state
Posted by GitBox <gi...@apache.org>.
hntd187 commented on pull request #1451:
URL: https://github.com/apache/arrow-datafusion/pull/1451#issuecomment-995217099
It's not and now that I think of it I shouldn't have just done this without asking why. I figured that ExecutionContext did not implement Clone which was why it was necessary. If I just missed the clone impl than this is probably a useless PR we can throw away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1451: All building execution context from another execution context's state
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1451:
URL: https://github.com/apache/arrow-datafusion/pull/1451#issuecomment-995214554
Thanks @hntd187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org